Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 23 Dec 2024 14:16:01 +0900
From: Michael Paquier <michael@paquier.xyz>
To: mahendrakar s <mahendrakarforpg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Last removed wal segment file
Message-ID: <Z2jyEUB01YFeIa-c@paquier.xyz>
References: <CABkiuWo_7Py0_RCbGKW=oEod4PFrFBM716qytdO3e-PK68DE9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="w9PlkCgGyLvBktEP"
Content-Disposition: inline
In-Reply-To: <CABkiuWo_7Py0_RCbGKW=oEod4PFrFBM716qytdO3e-PK68DE9A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z2jyEUB01YFeIa-c%40paquier.xyz>
Precedence: bulk


--w9PlkCgGyLvBktEP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 23, 2024 at 09:22:06AM +0530, mahendrakar s wrote:
> Is there any psql utility function that returns the last removed wal
> segment file?
> I see there is a method: XLogGetLastRemovedSegno in xlog.c.
> Would be happy to add a new psql function around it (similar to:
> pg_walfile_name, pg_last_wal_replay_lsn, etc other utility functions
> we have).

What's your use-case for it?  I have to admit that finding out this
information can be a bit annoying as it requires checking the state of
archiving and the replication slots from which you would get a LSN
(not a segment name).  Of course, one can use pg_ls_waldir() these
days and it would also work based on timeline number and even partial
segments which are not removed by the checkpointer.  That's more
expensive than looking at a single counter in shmem.

If you wrap a SQL function around that, the segment number would not
be enough to guess which segment is removed: the timeline of the file
removed should also be added.  Hence XLogCtlData should be extended
with a kind of lastRemovedSegTLI or equivalent to be able to rebuild
the file name from the data in shared memory.  Note that
UpdateLastRemovedPtr() extracts the timeline number, does not store
it.

Also, note that UpdateLastRemovedPtr() has a small race condition when
it comes to monitoring: it is called before the file is physically
removed in RemoveOldXlogFiles().  It would not really matter much in
practice, I guess..
--
Michael

--w9PlkCgGyLvBktEP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdo8hEACgkQnvQgOdby
QH0Oeg/9GxpF29zKVA6fIId1J8Rez40ozB8nvAzfSbA6bjWcK16Byd1/cSVxLfQ8
9VcUATGHGjKNG4lzix10QBuLOwNolP6M/6A3qYdhTGlSaxaW4F3XWklakPzUCl+p
MHn5S/ctOdT3wwpz+bip2zl3V5bKy206koUmCi9QIN12CSa2BmFJwvE3tuhaPjVy
ELs2qh+U3D9yY4ZTq3dmQv8fg+Rw2qRNuFAMJoaXI8+xIovBa+t+4GwVhhNNIrDe
ZxSqHWLeWAbZp4d4zgEipBoedccDSMy1EmR6Wi4sw+40PnKeaBvKCZkyplDdga1z
wFnh7PFSKH11YO4DjB8tMZdXr+8v2PDbG31Jvk/t1vmTWUpu3VcgcgPrhiruy5cT
z6tAuuRMwNCWXV0boDJE/Yb3YFaRsbXmKXVNECDe25K8owhNW7VSzu9pNzo0+EmS
C/ZKDy5XuNnAkTJ06OO2ybe004w2t9/IjprmxUX9g1BMO5xVHmBJzHpljlTqSM22
LLyoaFrc1kR7NALYWCU8igjK+8u9P2zBM+QVkAenn/gGxV6/sgvAakS1BFmkluJl
ZyQulAnnJf4OVXfexolLXfDpzu+GP4IQ0OqGowgUlEnyymoJf8/PGAg+Qa0sNGrK
g/u5uqYx5rpZa0Q5PPIQdM01wtvThA1NowM5yv/EG88+opJLsgo=
=bf3c
-----END PGP SIGNATURE-----

--w9PlkCgGyLvBktEP--