Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 24 Dec 2024 16:33:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Joseph Koshakow <koshy44@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: date_trunc invalid units with infinite value
Message-ID: <Z2pj22b9qZryFIRo@paquier.xyz>
References: <CAAvxfHc4084dGzEJR0_pBZkDuqbPGc5wn7gK_M0XR_kRiCdUJQ@mail.gmail.com>
 <Z1E7cTyVbFZJwUWf@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rQAJubo2rkzNry5p"
Content-Disposition: inline
In-Reply-To: <Z1E7cTyVbFZJwUWf@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z2pj22b9qZryFIRo%40paquier.xyz>
Precedence: bulk


--rQAJubo2rkzNry5p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 05, 2024 at 02:34:41PM +0900, Michael Paquier wrote:
> I agree that it is inconsistent that we allow infinite values to go
> through this function call even for fields that are not listed as
> supported by the documentation.  So, yes, I think that what you are
> doing the right thing by applying the check based on the units
> supported, but I also doubt that it is something that we could
> backpatch as it would cause queries to work now to suddenly break.
>=20
> Thoughts and comments from others are welcome.

Hearing nothing, I have looked at this patch again and I think that
I'm OK with your proposal.  While the discrepancy is annoying for
back-branches, this causes a slight change of behavior, so I have no
backpatch in mind.

I am planning to get this one applied around the end of this week on
Friday for HEAD, that should be enough if there are comments and/or
objections.
--
Michael

--rQAJubo2rkzNry5p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmdqY9sACgkQnvQgOdby
QH2hoQ//ftnbU2LuONAD/RpdW5m9lDwgbQU1CZEad3dX1WrtkBIU7TpjifHPLBwe
u1HEKlOoFqqkgX+0J/1JwBSaKSrrihuFjxj4zS7XQdn3sH2YvuB1zBpEfRzfUvfX
SVXZ7V9za/lU4plVJr+Pzxgjj+1jUf8YzQC+mKsiQdzbs0Vbq40sQfLqpDvtKMJy
/HoNdQ9T1Ajof3Zla+lmcus4aM5w3i5LqqqZN6AYna9jZCdJum9f7h9TSPnUC2uA
ENyu5jO8VVupbpL2g6z7ynfVXPnfSJHdlAj8hwHo1VyjX6nbDE6iDeCPkDm+Wbpc
/75blpGUfF/1drJMoodTaYNOnIfw69kaosVWyo92aS+J7oFFUm6+g+rMVBvXy3LB
KM8z3LR6Xx6Z+1sq5zPiVms3s0Hpdjb4s4DHYZzGOp95+jyl4EwC32dMzPrKOJyh
n9EUYIa78lk3zn7z5C2P0Bp1s0LrtzVVBDIAEKZBsPuwvXySPqZXggtkXke3PT6V
KrxMGswoULeg5p6F7MVaOVga19HSxQlmbiM3TEEFf/hNQWmLSqyg4kBpz2HJ455p
fQFHepj0gAClfgAWBaEgkVCDmaslxN6bVosF3X539D1Guz099/WtO2HyAi21EPth
Y7+k/KVAR7F02aamX/KqxmRBDpSEO+DWYqVusKjI0IX6kDphgKI=
=SDGN
-----END PGP SIGNATURE-----

--rQAJubo2rkzNry5p--