public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 06/10] Default to LZ4.. 2+ messages / 2 participants [nested] [flat]
* [PATCH 06/10] Default to LZ4.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) this is meant to exercise in the CIs, and not meant to be merged --- configure | 6 ++++-- configure.ac | 4 ++-- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 9b590eb432..3afa1e87e3 100755 --- a/configure +++ b/configure @@ -1575,7 +1575,7 @@ Optional Packages: --with-system-tzdata=DIR use system time zone data in DIR --without-zlib do not use Zlib - --with-lz4 build with LZ4 support + --without-lz4 build without LZ4 support --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8598,7 +8598,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h esac else - with_lz4=no + with_lz4=yes + +$as_echo "#define USE_LZ4 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index 2b3b5676eb..d62ea5f742 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_MSG_RESULT([$with_lz4]) AC_SUBST(with_lz4) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index f33355e44a..609d954a3a 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_ZLIB; +int wal_compression_method = WAL_COMPRESSION_LZ4; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index c37a8313d3..52f9cd0242 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_ZLIB, wal_compression_options, + WAL_COMPRESSION_LZ4, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --0qVF/w3MHQqLSynd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0007-add-wal_compression_method-zstd.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: An improvement of ProcessTwoPhaseBuffer logic @ 2024-12-25 22:42 Michael Paquier <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-12-25 22:42 UTC (permalink / raw) To: Vitaly Davydov <[email protected]>; +Cc: pgsql-hackers On Wed, Dec 25, 2024 at 07:18:18PM +0300, Vitaly Davydov wrote: > I tried your patch and it seems the server is started > successfully. But I've found another problem in my synthetic test - > it can not remove the file with the following message: > > LOG: database system was not properly shut down; automatic recovery in progress > WARNING: removing future two-phase state file for transaction 1045224 > WARNING: could not remove file "pg_twophase/FFFFFFFF000FF2E8": No such file or directory > LOG: redo starts at 0/1762978 That works properly up to v16~. I have slept over this problem and I think that we'd better backpatch the fix for the first problem. Now, I also want to add a test to provide coverage. As you say, that's simple: - Create an empty file with a future XID name - Restart the server. - Scan the logs for the WARNING where the future file is removed. > The fill will never be removed automatically. > I guess, it is because we incorrectly calculate the two-phase file > name using TwoPhaseFilePath in RemoveTwoPhaseFile in this > scenario. It can be fixed if to pass file path directly from > RecoverPreparedTransactions or StandbyRecoverPreparedTransaction > into ProcessTwoPhaseBuffer -> RemoveTwoPhaseFile. Yeah, I've noticed that as well. We are dealing with a second bug that affects 17~ caused by the switch to FullTransactionIds for 2PC file names, which had been introduced in 5a1dfde8334b (pretty sure that it is the culprit, did not bisect). Attempting to remove a future file triggers an assertion failure: #3 0x00007fed046324f0 in __GI_abort () at ./stdlib/abort.c:79 #4 0x0000563e68a9bd07 in ExceptionalCondition (conditionName=0x563e68c66fc3 "epoch > 0", fileName=0x563e68c66b0b "twophase.c", lineNumber=953) at assert.c:66 #5 0x0000563e67683060 in AdjustToFullTransactionId (xid=4095) at twophase.c:953 #6 0x0000563e67683092 in TwoPhaseFilePath (path=0x7ffcb515b4a0 "h\307!\227>V", xid=4095) at twophase.c:963 #7 0x0000563e67686603 in RemoveTwoPhaseFile (xid=4095, giveWarning=true) at twophase.c:1728 #8 0x0000563e67688989 in ProcessTwoPhaseBuffer (xid=4095, prepare_start_lsn=0, fromdisk=true, setParent=false, setNextXid=false) at twophase.c:2219 #9 0x0000563e676872a6 in restoreTwoPhaseData () at twophase.c:1924 #10 0x0000563e676b5c8b in StartupXLOG () at xlog.c:5642 So this means that we are dealing with two different bugs, and that we need to fix the assertion failure of the second problem first down to 17, then fix the first problem on all stable branches with a test to cover both the first and second problems. > I did it in the proposed patch > https://www.postgresql.org/message-id/cedbe-65e0c000-1-6db17700%40133269862 > (it is incomplete now). I suspect that this can be still dangerous as-is while complicating the code with more possible paths for the removal of the 2PC files, because we may still build a file name from an XID, and that's what's causing this issue.. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-12-25 22:42 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 06/10] Default to LZ4.. Justin Pryzby <[email protected]> 2024-12-25 22:42 Re: An improvement of ProcessTwoPhaseBuffer logic Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox