Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVNWw-007mQq-MX for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jan 2025 04:18:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tVNWw-00CHLg-2p for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jan 2025 04:18:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVNWv-00CHLY-Ax for pgsql-hackers@lists.postgresql.org; Wed, 08 Jan 2025 04:18:53 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tVNWs-000Roz-1s for pgsql-hackers@lists.postgresql.org; Wed, 08 Jan 2025 04:18:51 +0000 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id 1E7D9254018C; Tue, 7 Jan 2025 23:18:50 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 07 Jan 2025 23:18:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1736309929; x=1736396329; bh=BZFmAZNpue 7k0dYHafNnIIBZkPd3Alum0VE05gb5N8k=; b=QzcjFIUNANR9QIOAaWH3feGKAG 00wsRHgYB9j9uXOCCQt5Vgr09mDvfbM9KaUy8DcYyatCwsxQxXR9pRevOMzHuygF xPmXO/SH3QNq31jLAP6eI0PgxJN15d0Gk7uWQ+ADqjYGmIlouwLIlNbmDdydBin6 SkGhttAJ2+tyK4Ecwg0tjkjTEiYTy/ftWnzqHjoewwQEPIbjSWF0iKLPKURV8ELL HwbUbpR+Ayoz1U46o1u+NsDED992pm8YAgjQbVkxiWX9VcurjM2BONGbj9TKqGS5 AAls86/3kunK4FeXino9IMZJL0xtIAqHWKSuDCgxtqs1NBzgogP8mS6PUAEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736309929; x=1736396329; bh=BZFmAZNpue7k0dYHafNnIIBZkPd3Alum0VE 05gb5N8k=; b=pKXp3Fr6SIgy/IF0u5ZIJTJ5Ch8wb/LjESu8u3nhFk3sU9MMJkI AF2Ma+BnQmCfdUmLxXvq3+LTuC7uJ+GCCsvyiEma+UnDAzhxVjyylazMd2CcEVyg Fdar7iy3iSXR5U+kNz9EcKBo+tqxdo3wEdW+eIi4Aiy+yJ3y7mX5oXAhCyKfw2CH DjQ6POyP+syuXemT8t2KqV5P+PAtlYtQVTIz6Mpl6oqxWvRM/s6iNb8uf8uKWPQK IWcjFKSJWVkgU+gD72DrbkKI0f7l5D3dmWL7ybWtWKu6qyad9Bc457afiwuMMGbW S9vFaYkh0Nc+z1xVeei79owarzQq8ayvdTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudegfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepnhhorghhsehlvggruggsohgrthdrtghomhdprhgtphhtthhopehr ohhnrghnrdguuhhnkhhlrghusegrihhvvghnrdhiohdprhgtphhtthhopehtghhlsehssh hsrdhpghhhrdhprgdruhhspdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhi shhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepphgvthgvrhdrvghish gvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Jan 2025 23:18:47 -0500 (EST) Date: Wed, 8 Jan 2025 13:18:36 +0900 From: Michael Paquier To: Noah Misch Cc: Ronan Dunklau , Tom Lane , pgsql-hackers@lists.postgresql.org, Peter Eisentraut Subject: Re: Converting contrib SQL functions to new style Message-ID: References: <3395418.1618352794@sss.pgh.pa.us> <3133933.1730855116@sss.pgh.pa.us> <5829980.DvuYhMxLoT@aivenlaptop> <20250106190428.ec.nmisch@google.com> <20250108025233.12.nmisch@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ke+uFf7oKxKaaC24" Content-Disposition: inline In-Reply-To: <20250108025233.12.nmisch@google.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Ke+uFf7oKxKaaC24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 07, 2025 at 06:52:33PM -0800, Noah Misch wrote: > It's more optimal to write '0'::bigint. That generates a CONST node, whereas > 0::bigint generates a FUNCEXPR calling the cast function. No other concerns. Makes sense, done this way. -- Michael --Ke+uFf7oKxKaaC24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmd9/JwACgkQnvQgOdby QH2L8RAAj3nxgIUr8Eb2yiIJIkDtN1KDjbOw+sPhEPty85tbmlMQHh3zR5ZjbVYB K9fK9ch043Omcju3JJDH9kRd+gm1BbfPvLjt7UIXOQyR9hB7mleBgcqW/I1TmwK9 7E2kzX8dzIlkv3lln4K6WUaNd2dw53BjREhiIzTvf/WyAEebirumF9+TEMx2MXGe HtiRYOpMluV2OzECf3DpGS9H2LDHwgR2BI18n8fzjaMbuOLectZrSqwcLpAT23Zo d2TOAVq9TOSUlNmItUPxlZAuQMZp++gyMA3IQ3y2HnPxo21A1qEbRwgms2cy2UMy sjI/MnTovx/G9ncmFLkJ+FCp90590lZ+XyrgKz1SQE+RQRjSBT3b1UZv6TOel/PV VnsdMem3CrhEBsqFKmS+y3yEX26TuR/0vz8hs2TtodFVwO0KP+RM9faqAj1LEjrw 7mqq3OEhOrYEXnrmMOfCrEoccgZ8o387F4CEK+v2u42cKhUPVHImHjdRnluxjUgi 5TjnKgiTJZaRVyBVOi/uCJZLv9lYdu4DtKUQ+Zpxhp5kJ9ZAHLmNaSbrFDfUtM8b t1nGPSEJbhOKFgkfqSorTJDoBPwYdEbpGQz712rB3v41q1k+nQQ8rkyCFw4t7F8A FOEQDX6WkZFR7Ho4Lrn5x62yG9tEGRMgQZcxtdZUtS6z3WWfjeE= =oTub -----END PGP SIGNATURE----- --Ke+uFf7oKxKaaC24--