Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Jan 2025 11:32:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Ronan Dunklau <ronan.dunklau@aiven.io>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@lists.postgresql.org,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Message-ID: <Z33joDRv_r_gJSd9@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us>
 <3133933.1730855116@sss.pgh.pa.us>
 <ZysEEDZqsnP7GTKA@paquier.xyz>
 <5829980.DvuYhMxLoT@aivenlaptop>
 <ZywSnWzXskAxSDew@paquier.xyz>
 <ZzMSJkiNZhimjXWx@paquier.xyz>
 <20250106190428.ec.nmisch@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bc8TuMW5s8JzDV+S"
Content-Disposition: inline
In-Reply-To: <20250106190428.ec.nmisch@google.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z33joDRv_r_gJSd9%40paquier.xyz>
Precedence: bulk


--bc8TuMW5s8JzDV+S
Content-Type: multipart/mixed; boundary="DrznTxUPd9gsfIWB"
Content-Disposition: inline


--DrznTxUPd9gsfIWB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 06, 2025 at 11:04:28AM -0800, Noah Misch wrote:
> Per postgr.es/m/3489827.1618411777@sss.pgh.pa.us and
> postgr.es/m/1471865.1734212070@sss.pgh.pa.us one requirement for migrating to
> SQL-standard function bodies is removing these inexact-match function and
> operator calls.  Here, one could either write pg_catalog.generate_series or
> make the argument types match exactly.

Thanks for the report.

Tom has used casts for xml2 in 667368fd26de, and also combined some
pg_catalog for schema qualifications in citext for example.  In this
case forcing the data types seems more elegant to me.

What do you think about the attached?
--
Michael

--DrznTxUPd9gsfIWB
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="freespace-bug.patch"

diff --git a/contrib/pg_freespacemap/pg_freespacemap--1.2--1.3.sql b/contrib/pg_freespacemap/pg_freespacemap--1.2--1.3.sql
index 7f92c9e92e3..a75c4d8642b 100644
--- a/contrib/pg_freespacemap/pg_freespacemap--1.2--1.3.sql
+++ b/contrib/pg_freespacemap/pg_freespacemap--1.2--1.3.sql
@@ -9,5 +9,5 @@ RETURNS SETOF RECORD
 LANGUAGE SQL PARALLEL SAFE
 BEGIN ATOMIC
   SELECT blkno, pg_freespace($1, blkno) AS avail
-  FROM generate_series(0, pg_relation_size($1) / current_setting('block_size')::bigint - 1) AS blkno;
+  FROM generate_series(0::bigint, pg_relation_size($1) / current_setting('block_size'::text)::bigint - 1::bigint) AS blkno;
 END;

--DrznTxUPd9gsfIWB--

--bc8TuMW5s8JzDV+S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmd946AACgkQnvQgOdby
QH36UhAAp/Dlnn7uUZqeNGWHSckbuVwO40xHyAvNQ2z63aa6wm300KUR7RLoihmw
dQMao7FwAV4rD0x9NvpZ6b1TyGQB+Xje0gPDca7G8XdkLdzcklP3LcL37ucHvB8Z
lQkRGtJys/JhBafuzLyEclq+GN9pHUE58+B+4x15Ce1DIaH0l231ZaZQ/7nVW2l4
RtGFqyf+TLvS/D+UWQgco1ckti7F7JUwgIY4k9U1NbPGFAMt3Ic7heKCEQ8czPOD
1ycW9yp4E2t7AIRuQb7rLRFERcBNUc+jG0nACJ2gnT5WeSUbUMhGOj4bJKfVGLIX
B3dQAyUcEI0NVJxAglmDesKZHuXnO0FR9yMUHxRldXqllFl8kGpe1zNjgQYFeLOV
bx6PbuA+ReR5xAQG3XV4pKjJJ1TuC6310QOWHaOD8qdmsVABX0WTk6GdiwLChiID
gufIagcybbAehdg7qGyxqGXA3iK+y7fYKn7oAXKNnxeCxmQLhn5pwGv1gSjzNaoD
EHkEwf0ZVQt9qXoxhOpX/T2zpNTjBfHTZaAnjsA/5XvBdVRQyZjeV25HqMDgPl9a
LCpOqfS+ieIJ0fbRxXiVTUV9sl161w0FP/8UGrZh5Y1DejsWCxe65/ayshxjQ0CO
+PAL49XOjZrH8I9HCRQht+aN2Nk6FNVennuyPrUUoFSSXOqEdxQ=
=lpKf
-----END PGP SIGNATURE-----

--bc8TuMW5s8JzDV+S--