Date: Mon, 6 Jan 2025 15:50:24 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	"Imseih (AWS), Sami" <simseih@amazon.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Message-ID: <Z3xQIPX3aeri4DiT@nathan>
References: <Znc3R8nkAx9et-t_@nathan>
 <Zow-DBaDY2IzAzA2@nathan>
 <Zpq9dx37tdUkV42U@nathan>
 <ZqVZSQlgpmy6MM5X@nathan>
 <ZsY96PvqkoJaC2Y-@nathan>
 <ZzzMcv0lAdY4OzGi@nathan>
 <Z2XJjI8fO8ksOv4E@nathan>
 <Z3v8UFk0sOgFgWeZ@nathan>
 <Z3xFE7DQTSRJw2FM@nathan>
 <1346002.1736198977@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1346002.1736198977@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z3xQIPX3aeri4DiT%40nathan>
Precedence: bulk

On Mon, Jan 06, 2025 at 04:29:37PM -0500, Tom Lane wrote:
> Unsurprisingly, this has completely broken buildfarm member sawshark:
> you added 13 new semaphores to the system's default requirements,
> and we only had headroom for about 4 (cf. 38da05346).

Oh wow, I missed that the defaults were so low on some systems.

> Now maybe we should just abandon the notion that we ought to be
> able to start up under OpenBSD/NetBSD's tiny default value of SEMMNS.
> If so I'd be inclined to go revert 38da05346, at least in HEAD.
> But I kind of wonder whether this feature actually brings value
> commensurate with causing installation problems on real-world OSes.

I'm obviously biased, but I think it would be unfortunate to block features
like this one because of low settings that would otherwise be unsuitable
for any reasonable production workload.  If we do want to at least support
check-world on these systems, another option could be to simply lower the
default of autovacuum_worker_slots to 7 (or maybe lower).  Of course, that
only helps until the next time more semaphores are required, but that's not
a new problem.

-- 
nathan