Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVx8e-00Cvlz-8k for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2025 18:20:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tVx8d-005xoU-OD for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2025 18:20:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVx8d-005xoE-EL for pgsql-hackers@lists.postgresql.org; Thu, 09 Jan 2025 18:20:11 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tVx8b-000kR1-0Q for pgsql-hackers@lists.postgresql.org; Thu, 09 Jan 2025 18:20:10 +0000 Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-84ceaf2667aso77084739f.3 for ; Thu, 09 Jan 2025 10:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736446809; x=1737051609; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=551TgzZD9HPBkC+U04aN/5s9eMGtKsjaQ8dCraDHKmU=; b=dGL01pxpvEuJdzqQCPqDAAEiF7UnNLK9GmlG8s5NZamz9kdTwSh5d/d1JvpU5W/fSM qDNKogYlPAP5cjGciNlvGB6e9MHFd/F3329Jo4N0Y3eFKLTYKAMzn6/HezjRD3k0SETu fcm/mKpVzYibYFnTMFFgbzSt+2FTtmyPIgQMOfDkSawXSTiLhuk9iUXO9DLvJ7GtOZWY ZIpvZvpalohLKaxUPMUe6zF5A3Jyqe7XeCbUwDeCICTae66G6MJFHxs4GK2/G8+M6SPN bazLf8yzJPNSRD/fLbrUjkqTwqNmoBYQ5la5oxXCYFkvqjKqiJFbWwnupBODYDFAmJX2 ZENQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736446809; x=1737051609; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=551TgzZD9HPBkC+U04aN/5s9eMGtKsjaQ8dCraDHKmU=; b=IibhbekHLt23Y/022gJdmcIxy4LIS7H24Zq7QKqJTTL7JVyOqs6lrvx9P3mm9ofaOg RxGKvoghxAo3dr7/4Ldi7ksxOaHnXiAkHD4ufFXyu10YWBcbTqa7YWhuyDmoHZhK9QK5 n/YRk1yy7IsMc2PcigxQh+YM2Fftt27reyiHX7DgldN6HlWgBMZPOsPtW0ULfOliWGL2 vWkjj13QJleKnMNFgm3nj/DTqSy8TugojBHvOhYdDR/e3VgqV6K9vu/mUJZArzVXoUWd /WX0Dh1OjsQmd3+f2ZGVGnr4PW5ppLQgEfULfE++6IPC95NZfyopwisA32yEmRMJB0Hj aZ8Q== X-Forwarded-Encrypted: i=1; AJvYcCXGYxzlcLbtugcun+6aYJSv+y/laMmpQOKdBrsFbryn+JJrxv2b9XVvS/VignZQPjjv7Ac1QZWzI0VGO130@lists.postgresql.org X-Gm-Message-State: AOJu0YzaFXzx76xoplfFUp8tO27CMFNnMeOFrL9m7gGYq8HIwgyscY25 sght1G9fxHxraqgLJRCt/zxMjzGcxxwkUjepN4RF2bkLXzhh4vIz X-Gm-Gg: ASbGncufqV2wjsuzF5sNrZ/jAg/E3iZp9uv0H7hfDI8eNqNeH6sO2ahVsZLzH4DLDvN GxeE8xxwrbCtrq+044HsxTAEevxDuPqELNse9rmQJ2VKhFRp0E/gNWq8QVqJ2aeenDJS6yVvLh6 Op/bP6R05iNraemcpUSMWjNES79d+r1J6O1sHo78B8nfTrRt24UFEi2UQuVO7bJNwybfJDChwaV o8Y2H9p+wASRcJyadcBndYDd1u+Vq1CrvBp2Je+n3jfk8kBgJQgAFfxSh1BEXFdnfSFs6vAGQby Dw5ukyuXkpOhvIlq/gTtD0RZDYRw2ABXadEmvcML/tEGzh8= X-Google-Smtp-Source: AGHT+IHoUHYV9zlkb6i0+nqMx0mH1GQGQrWSn8OGT1vbFwv2VKXMh1vs+AHM0GERJa5wHiGSV9NhDQ== X-Received: by 2002:a05:6602:418c:b0:84a:7906:d988 with SMTP id ca18e2360f4ac-84cdfddfd3amr781380039f.0.1736446808740; Thu, 09 Jan 2025 10:20:08 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-84d61fc893bsm45098439f.43.2025.01.09.10.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 10:20:08 -0800 (PST) Date: Thu, 9 Jan 2025 12:20:06 -0600 From: Nathan Bossart To: =?iso-8859-1?Q?Vin=EDcius_Abrah=E3o?= Cc: =?iso-8859-1?Q?Fr=E9d=E9ric?= Yhuel , wenhui qiu , Robert Haas , "Imseih (AWS), Sami" , David Rowley , Joe Conway , Michael Banck , Laurenz Albe , Melanie Plageman , PostgreSQL Hackers Subject: Re: New GUC autovacuum_max_threshold ? Message-ID: References: <2ca7f9c7-5da9-46cb-9072-39b71bfab948@dalibo.com> <93f3dab5-caa4-4213-9be0-855d5aaa19bf@dalibo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jan 08, 2025 at 09:32:58PM +0000, Vinícius Abrahão wrote: > Please also provide the tests on the new parameter you want to introduce. I skimmed around and didn't see any existing tests for these kinds of parameters, which of course isn't a great reason not to add tests, but it's also not clear what such tests might look like. Do you have any ideas? -- nathan