Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXuXc-00GHpu-Py for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 03:58:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tXuXb-006cQT-2s for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 03:58:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXuXa-006cQK-PX for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 03:58:03 +0000 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tXuXZ-000TDY-1k for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 03:58:02 +0000 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-844d5444b3dso19262539f.1 for ; Tue, 14 Jan 2025 19:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736913480; x=1737518280; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xtP3FuXT0whSpKTKc5oj3HijHeQ/yBbL7VmdugQtjqA=; b=AbPKip1+CSvAX9I2nCn5V5VtBOuzKalwCXoOmik/y4pJjbYt36iR5LN7GmpPGjug7l 8wehYgpR6pYsOFxXb9locH0t/9pE7/CJPEKkr3S5y0mhThBOkzEJpvCCvCaotBQxhCbL flXCq2SPt2pKak4SHuVTYHx/NLK+RRMklEoZVFkMuIoIFe8SM0sWpeoiLZSBh0DjRG6M jxOttblwRb3dqiduIAZK7byOF0jIyCcst8fVL9Yhl2gfVfKdUUZliOw4mP8PHqvvh6o0 EjmA24s5SoBIE+kb7yb4gvGD7wz2fWbXBlHW4UTZKm2ME6W3jw5w6MQcn9tf2HNRkuue Z5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736913480; x=1737518280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xtP3FuXT0whSpKTKc5oj3HijHeQ/yBbL7VmdugQtjqA=; b=uMmrlyQubyJ3xNuKnlhmQmtdZ9/ak3Ek3muatcYhJVDfiHgeM8HJ5sUIAK9v/UvWU7 RKc/0bcx3457kpGunv2VKGS32gKcvcffTMUOGU3z1NRxpchN/jxxV5j0e0PGHI7Em/cn ZYkg2782fdkZPi4Gb5lmyJjXh/euli5V+V0T2hS/Bk+SON8tRMgDquHT71YosdsKaIAk hQ834KIsS4mYK1xm5kXQC0i0XM79ARrIix/TlFGJ2F2JPqDS6e4JpiiwmWtXCd9OpLHx WACZ1bS24ll4du9UIlH0AWVc1zMPQiJV7MVsW3IFugaekBlvPYpmNCvJd5ElAPEzbG8k kJMg== X-Forwarded-Encrypted: i=1; AJvYcCXpTUrNz05OmcGFJViVzmThIX9W7AthunLQZmrQflsxyo72ax59UKJWoAftzSA//cH0PECef2kwNyv07YDX@lists.postgresql.org X-Gm-Message-State: AOJu0YyuZDsKMFmmSn/3+nVtlCn3Hg5mjuXWbJAlhNW80e8nC/j242xK Q4NX/gYnQPKvikqnAeYwO5oucsBRoyVncP1uyPToM/unSFI9opBN X-Gm-Gg: ASbGnctvicZNolp/DVRfDpr2Kbq4oLJPcHclbIU6Hr1M5tPqwfqk/N7UrKhId0OeB7C p4Hf7+WUIXu9ajK+t8Rp8kd4MJyy4ooKt6hbkOPZSXZLcgY6DuB13g/D+M1gMNBG8xJjhKYuZ2d OY6RaJaSh8oM9o1WKsX1xE7WMFxIz3FSRpsFqnStoUc1X5/NxG31CLE8OND1HavOSWa46bkc8rT 8lQpB4Iw+BtWblVkMgLJvyx1pRP0k7tGLm0OX6Lmi2bsBU9Xj67zIoAtPR819tQ30dsnVTp6lvs qE1Ov7Wa26kORN+xKCBDs4y/EC9k88cD/zjTnXsUSKDyeY4= X-Google-Smtp-Source: AGHT+IE934caA1MsvBvKEp7AGCIHsHOZi/v45VoQfRmcu3Ah4RfVvLKttQW9GkJMg6VX4M95KOkm1g== X-Received: by 2002:a05:6602:4745:b0:835:39a8:e201 with SMTP id ca18e2360f4ac-84f67175a09mr129467439f.0.1736913479750; Tue, 14 Jan 2025 19:57:59 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b6292ccsm3856704173.73.2025.01.14.19.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 19:57:59 -0800 (PST) Date: Tue, 14 Jan 2025 21:57:57 -0600 From: Nathan Bossart To: Tom Lane Cc: Fujii Masao , Andy Fan , pgsql-hackers@lists.postgresql.org Subject: Re: convert libpgport's pqsignal() to a void function Message-ID: References: <1164438.1736910166@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1164438.1736910166@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote: > LGTM, although I don't know enough about Windows to know if the > "== SIG_ERR" test in that path is correct. It's apparently not [0]. :( My guess is that this has something to do with redefining SIG_ERR in win32_port.h. We might be able to use push_macro/pop_macro to keep the old value around, but at the moment I'm leaning towards just removing the assertion in that path. [0] https://cirrus-ci.com/task/6237809813487616 -- nathan