Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tY8Su-004NG7-JC for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 18:50:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tY8St-00FYSv-76 for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jan 2025 18:50:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tY8Ss-00FYSm-Tr for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 18:50:07 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tY8Sr-000bGV-0P for pgsql-hackers@lists.postgresql.org; Wed, 15 Jan 2025 18:50:07 +0000 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-844d5444b3dso6793439f.1 for ; Wed, 15 Jan 2025 10:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736967003; x=1737571803; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ngHwrC3NyrEX1yaRqbjk+PuhzIUBT3bTYH+7b7ndh6A=; b=MaIXwN3NyaPxR6kDWZRXpVPZ4T/BIYhUdaavDi8Zkme/nZL3IHtc9s5dyjJc5Kpt3V D/XSN79rzL2yGnjGLMDXv+3PoAXuXSOoWHqmmeIfjwZxcopDcKm1aTEftGAl+HmTeQje 28RIkecrVI775Kv9NXYPI1ANG6IKsFTBsnyqaHTywhOa05pmnZ5QQjrIwTzhkbQ5Bzq3 yZG0Nozo4dMP5cQec6hrPAvuoWQaxa4+7P0sLFmFBVY9kshzj/8gHk1yDKNiunx4rD6C xrQp2rcZ5NDWYLkSJlSnj8wrkj7HYKSIji/uthqAe7/tSgcAElzb9DohdjyDcem66qhY HrGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736967003; x=1737571803; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ngHwrC3NyrEX1yaRqbjk+PuhzIUBT3bTYH+7b7ndh6A=; b=Z8q/G9xMeRZeKIHdAoeyVa1ERmLQHOrAHH4GDL5jtFpjjVcc8vhyU+MFWKgAWmpgvc wCwAo/Oz8Z764SoBxF7x36TWLcXi3WGx5DtFeZ2csaZIK52vgFX0Abu4k+H95VQ7lPQe iTN1n16e/6YZByd3Syu1P6aPofQEaLT2oBqPpUdPWWeezHsxqesi2lwSdPoHwyluqZrd rPq+nImjOeO4B4OlyfoQ65CiHKfnjSv5AY7i7yaUl/RWHIpKWrZOINvbI6BxHXg89kif RM9VlwBJCGeQY0G63wynPqEqhgjyEFpSCcDUEV6YTy68fxq58aa/V6WBoXuSOEMWVux9 KrVg== X-Gm-Message-State: AOJu0YwuUZh6qZfIm0qnK5N/IAjm0Uip4HXWuSgcfW2XvL4O9GjcVFX/ XS0g0Hq1oWeaNcXf47zGNHtQqXNFHs7P9Ruc8I61pSOFNSve0I6C X-Gm-Gg: ASbGncuOiHhE0FXo+jZ1lqaoeqBmBJc+Owk1FYON0bOZQdeOsBiQqBXaDwvdLrq+48s xj59zF4ReulFQH0ve/+xGP6Ck3IKPEnSeUFAtHIPadhfg/RfQEsT+55ngbgyZDcTmKoLHPk89qn ES/arQ3X/f1w7QCmmdyertXuwp5tKHnc02dUzGa0vNjBzn0i//Nl/kKoEnhS20/OMhbs02Q/pCa 9RlVLruKsia4y4VbBLws/N6r03AHNlbbsbPduhMQb24NHr0yrXRpuPvqRGU0KDxwtj4okYnJgeH bVrPB1HX3YXkeCrrhOTnen/3QfPkbDOhY0w9VzDT14CB52M= X-Google-Smtp-Source: AGHT+IH3OTs1J/WalbhbgwNZE8/WN9nqWpVv7/iJU251+badTY+wG9cf97rYbPOkGZUMZLhDMj01Zw== X-Received: by 2002:a6b:784a:0:b0:841:9225:1f56 with SMTP id ca18e2360f4ac-84f673f586fmr303864739f.3.1736967003028; Wed, 15 Jan 2025 10:50:03 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b6141e3sm4306201173.59.2025.01.15.10.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 10:50:02 -0800 (PST) Date: Wed, 15 Jan 2025 12:50:00 -0600 From: Nathan Bossart To: Jingtang Zhang Cc: pgsql-hackers@lists.postgresql.org Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64 Message-ID: References: <74D40BAB-C23D-497E-8153-67B543663182@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <74D40BAB-C23D-497E-8153-67B543663182@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jan 15, 2025 at 07:50:38PM +0800, Jingtang Zhang wrote: > Seems that great performance could be gained if s_lock contention is severe. > This may be more likely to happen on bigger machines. > > On c8y.2xlarge (8 cores), I failed to make s_lock contended severely, and > as a result this patch didnīt bring any difference outside the noise. Thanks for sharing. -- nathan