Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYIT1-008CQE-1U for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 05:30:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tYISz-005u5N-8c for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jan 2025 05:30:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tYISy-005u5F-Bi for pgsql-hackers@lists.postgresql.org; Thu, 16 Jan 2025 05:30:53 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYISv-000gPY-1B for pgsql-hackers@postgresql.org; Thu, 16 Jan 2025 05:30:52 +0000 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 4C10A1380128; Thu, 16 Jan 2025 00:30:48 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 16 Jan 2025 00:30:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1737005448; x=1737091848; bh=IIYvnhrMWA zDO/sTKbYaoMtNhd0XyAkTTi5Em2ETuvA=; b=hk9cP2LEJJ7iOFWi13nY4eVakg oDiN13NStzGbiRaFzyp0AIRvVKDOZ51T80SMw2J2a8XHvdfgzMs41sxvjuhg74hi OSSV+vi/2w4degNdvN9PgrcWQjoIWac//pfQPn9i+zQ8lBKn4M1drKjrQp4Tzm/t oyPyx8uaJCpZBbnUL8HKfKMha8LVxoFyXIthY6uult24xGfD0VnZir/e0grcUfyd 8CL3FDCgtz4KcAcEqXsnUhXyc/8G5nBG/jQS79WP6yyDiX3OBP/6QfC9cT1TB5D8 D/KVBZpSTuyp09Hq6oG837rD2a9vB19ifAMlTwa63l5F1tUotEsUgwoEJ4HA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1737005448; x=1737091848; bh=IIYvnhrMWAzDO/sTKbYaoMtNhd0XyAkTTi5 Em2ETuvA=; b=G1m/zh3o7X4DZBhqaZamKgQAu5N+lkut9wtQlQH7nUVu735isSZ zDaas3JaDkIWooFVZeY3q/351xxYwxPkk/BmcuHVy/NCqVK7LdSn0x93B6aNgPS+ VcYmfty/8wnXhXrRpIiHgkHEBBoYuIKndWR8SayvBoG5CmhldVoumqLI/cOgUvUk VdeDAsIQpu+GvmD8ymhqSbipiJFU29rLXqWRgOco6B9zDf8Mosd/RkXTOmH0XhhQ uIi8i/HH97lTzqmgqpzC5lIE8Zxbd6IuN0XdIvWYkWPZ+5qsk61qbapgnWX4Ge+g DOGQvPMPXrUSCAn54Y6iY78XdkPaqh7RO8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeitddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprhgrnhhivghrrdhvfhesghhmrghilhdrtghomhdprhgtphhtthho pehpghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtth hopehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Jan 2025 00:30:46 -0500 (EST) Date: Thu, 16 Jan 2025 14:30:36 +0900 From: Michael Paquier To: Ranier Vilela Cc: Pg Hackers , Peter Eisentraut Subject: Re: Fix misuse use of pg_b64_encode function (contrib/postgres_fdw/connection.c) Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IGYEYbbLVvsrQ2zl" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --IGYEYbbLVvsrQ2zl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 15, 2025 at 10:12:51PM -0300, Ranier Vilela wrote: > Fix by checking the return and reporting a message to the user, > in case of failure. You are right that it is inconsistent to not check the result returned by these two calls of pg_b64_encode(), as introduced in 761c79508e7f. Peter? -- Michael --IGYEYbbLVvsrQ2zl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeImXwACgkQnvQgOdby QH1n3g//VcksqBZiwAKbWGPV5dkXt1Q0IegzhPOqzvaif+1/yoMvoX0YdDCzSraq qQ8pPmn/HmoOAoj5NYKjLNqIjK/7VfBXLUOBfgMUp5H2n6NIibshNEtxLageVuIE cbvO/NlMbRXAubeIpswMkH4YUffmLvE7ZRjTWXXdcmkLAqRNm2uNCUCL28zOnGBN fDlv4vN2Zs5RSNGkI/KJGXzr1QNQRcbJ6OD6oBcR35CHLiX7JS04tMTKwThVgTEe Q0uCxGzDJLdmvCvXqlVbuJYXKjt81FRllbkV22ry2qOvT/xNqN723FszNF2z0ijj 4kPdzpjOdJFpG2JMwnfnzWkwZyYKOzKNDjrCUSaC8sQeOgi0Q5mKbhUEhiQ72JkS cg4hpkZQ65eZ3+6kYM5YvMpn6t0BvfwOMyUNBHgwiIjbCB1Qud4tAdBnJo3Dg+z8 O6JI7Qn0NghkbmGXQyqN1W1haiz7JFQGoaaGx/xWD67wR9rsmiW3CPo2Y9nsT3SO Rt+NUdiKYv77RD/y8vg+xqH88eIxdgvGFTbLaX9Kk4gqi8/m/Fsd/XEzp6TdKovm XEOQ6xMTVC2dg9LXK4zXR3aee/uceDr+3miWaPnu5BFuBIR7xQzYPqQivsh2cxU5 Rbc+pHgo4cIlJW9R/8EjFxOiX+pNbqfrWr0eOgP9xoIINKTRASo= =Qthh -----END PGP SIGNATURE----- --IGYEYbbLVvsrQ2zl--