public inbox for [email protected]  

help / color / mirror / Atom feed
From: Bertrand Drouvot <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: Andres Freund <[email protected]>
Subject: Re: per backend I/O statistics
Date: Thu, 16 Jan 2025 06:48:58 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAN55FZ0ZQTf-D+5Rup4H6zp+n3E2EuonYuzTiPkp=1GhesZU_A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAN55FZ1uOq=FVJObp0bdj-Z8q1ZRNmA-RymPqbMD+p4QaHXP3A@mail.gmail.com>
	<[email protected]>

Hi,

On Thu, Jan 16, 2025 at 09:55:10AM +0900, Michael Paquier wrote:
> On Wed, Jan 15, 2025 at 05:20:57PM +0300, Nazir Bilal Yavuz wrote:
> > I think allowing only pgStatPendingContext to have
> > MemoryContextAllowInCriticalSection() is not enough. We need to allow
> > at least pgStatSharedRefContext as well to have
> > MemoryContextAllowInCriticalSection() as it can be allocated too.
> > 
> > '''
> > pgstat_prep_pending_entry() ->
> > pgstat_get_entry_ref() ->
> > pgstat_get_entry_ref_cached() ->
> > MemoryContextAlloc(pgStatSharedRefContext, sizeof(PgStat_EntryRef))
> > '''
> 
> Yep, I was pretty sure that we have a bit more going on.  Last time I
> began digging into the issue I was loading injection_points in
> shared_preload_libraries with stats enabled to see how much I could
> break, and this was one pattern once I've forced the pending part.  I
> didn't get through the whole exercise.

I'll look at it and come back with a proposal as part of [1].

[1]: https://www.postgresql.org/message-id/[email protected]

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com






view thread (39+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: per backend I/O statistics
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox