Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 17 Jan 2025 08:43:57 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend WAL statistics
Message-ID: <Z4mZvW9ugvCOd_QH@paquier.xyz>
References: <Z4BmdUQQh8jzlPHq@paquier.xyz>
 <Z4DrFhdlO6Xf13Xd@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z4dRlNuhSQ3hPPv2@paquier.xyz>
 <Z4ks4+wnAz8eEyX9@ip-10-97-1-34.eu-west-3.compute.internal>
 <xibh465r3x7xvpzaozu47fxule3dktvwz4yacce4pjlw76lkjd@fjvm56zbev37>
 <Z4k9rb3aTNVSmyq/@ip-10-97-1-34.eu-west-3.compute.internal>
 <aj5vdgpbux5e2dbr6gcgd4eu3krjrflljt2neivh2vbkfrlant@2qedfymz7lmh>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KM9zLq0PTMCXY9oZ"
Content-Disposition: inline
In-Reply-To: <aj5vdgpbux5e2dbr6gcgd4eu3krjrflljt2neivh2vbkfrlant@2qedfymz7lmh>
Archived-At: <https://www.postgresql.org/message-id/Z4mZvW9ugvCOd_QH%40paquier.xyz>
Precedence: bulk


--KM9zLq0PTMCXY9oZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 16, 2025 at 12:44:20PM -0500, Andres Freund wrote:
> On 2025-01-16 17:11:09 +0000, Bertrand Drouvot wrote:
>> So, do you think that the initial proposal that has been made here (See =
R1. in
>> [2]) i.e make use of a new PendingBackendWalStats variable:
>=20
> Well, I think this first needs be fixed for for the IO stats change made =
in
>=20
> Once we have a pattern to model after, we can apply the same scheme here.

Okay, thanks for the input.  I was not sure what you intended
originally with all this part of the backend code, and how much would
be acceptable.  The line is clear now.

>> 0003 does not rely on pgstat_prep_backend_pending() for its pending stat=
istics
>> but on a new PendingBackendWalStats variable. The reason is that the pen=
ding wal
>> statistics are incremented in a critical section (see XLogWrite(), and so
>> a call to pgstat_prep_pending_entry() could trigger a failed assertion:
>> MemoryContextAllocZero()->"CritSectionCount =3D=3D 0 || (context)->allow=
InCritSection"
>> "
>>=20
>> and implemented up to v4 is a viable approach?
>=20
> Yes-ish.  I think it would be better to make it slightly more general than
> that, handling this for all types of backend stats, not just for WAL.

Agreed to use the same concept for all these parts of the backend
stats kind rather than two of them.  Will send a reply on the original
backend I/O thread as well.
--
Michael

--KM9zLq0PTMCXY9oZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeJmb0ACgkQnvQgOdby
QH2myBAAjhaSA5ifJsVhmJlz61NcOM1JX/SHSwtHjxmsmsyRqVlBDDaFR8BS2jEq
ScCLkelnZBJ8s5DN8zpRPHsvxT6qEt5KqOuDle2xhEYPcFUru4SOE3U53Whi2Cxh
1btVCa9fddVf1mxO92R9Z3djzOqncGfmBmDutGdFh8tL1vH7nG/0mTBuKAv8G2vI
zI6RUKfX1Vk5TpkAepy/mp4JEkzV9zhKMXIWpSDpdTiQLm+acCK8XAjdon++SHI4
HfV7CACw94TmFmL40v7bwrro5Uu1Dew2V2Dp1mdrhH5WAdYVEDKnDxu6lWp7oXZE
84JK+m4eHfMUGh6SGv3N3HvvwKffwzOemtMwx61hUOltB3dc74oJmxvlz/Qo67dX
Z9aORHlvv0QeoHN2cgLyE/9pzSBCaT75RQSByq46QCzZ1zhYb9xVLrIzK6qoKtrt
MdqnbNUYwhyjrYAqljUQI24svJW/N+0P1JQ7CqDkLgo9OzgdYkY13VpkG/mZejcO
E21cR8b/RRxiyr4KxU6hyaUVd0ZYjDi/20kd/cYzTbe9KKgcCdzohmbfVXgorRgD
KQo2lIF1os90DmaB01DxtrWvP7y7amb+16p47kL60njyca2U9VBCC0uDg4KV4bfd
uM+WgZh0ykGWMTS5PhxjjmyhUZlZ5L0Qb40jdywudFTLpI7oMgk=
=Lqmy
-----END PGP SIGNATURE-----

--KM9zLq0PTMCXY9oZ--