Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 17 Jan 2025 14:00:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Remove XLogRecGetFullXid() in xlogreader.c?
Message-ID: <Z4nkAQ-lP7fKInbP@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bprFPq7MP7Et3G/w"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/Z4nkAQ-lP7fKInbP%40paquier.xyz>
Precedence: bulk


--bprFPq7MP7Et3G/w
Content-Type: multipart/mixed; boundary="HFly0Z25TtFftSr2"
Content-Disposition: inline


--HFly0Z25TtFftSr2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019,
but as far as I can see this has never been used in the code and this
is used nowhere in the core code.

I have looked at Debian's codesearch and also looked at traces of it
on github without seeing it being used anywhere.  Knowing that this
was originally intended for a hypothetical undo log patch back then,
for which no work has been done for years, is there any point in
keeping this function in core?

This issue has been raised on a separate thread, where Noah has sent a
patch to consolidate a bit some epoch calculations for
FullTransactionIds, around here:
https://www.postgresql.org/message-id/Z4i6MbUlZxjK1rRh@paquier.xyz

Removing it would have the benefit to do a bit less refactoring for
some of the work of the other thread, and this removes all traces of
-DFRONTEND in xlogreader.h.  ;)

Thoughts or comments?
--
Michael

--HFly0Z25TtFftSr2
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Remove-XLogRecGetFullXid.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 101b8469dff3f35c9c3bcd24f1bcfff740f3a622 Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Fri, 17 Jan 2025 13:56:40 +0900
Subject: [PATCH] Remove XLogRecGetFullXid()

---
 src/include/access/xlogreader.h         |  8 ------
 src/include/storage/standby.h           |  1 +
 src/backend/access/transam/xlogreader.c | 34 -------------------------
 3 files changed, 1 insertion(+), 42 deletions(-)

diff --git a/src/include/access/xlogreader.h b/src/include/access/xlogreade=
r.h
index 9738462d3c..18a67acf42 100644
--- a/src/include/access/xlogreader.h
+++ b/src/include/access/xlogreader.h
@@ -34,10 +34,6 @@
 #ifndef XLOGREADER_H
 #define XLOGREADER_H
=20
-#ifndef FRONTEND
-#include "access/transam.h"
-#endif
-
 #include "access/xlogrecord.h"
 #include "storage/buf.h"
=20
@@ -427,10 +423,6 @@ extern bool DecodeXLogRecord(XLogReaderState *state,
 #define XLogRecHasBlockData(decoder, block_id)		\
 	((decoder)->record->blocks[block_id].has_data)
=20
-#ifndef FRONTEND
-extern FullTransactionId XLogRecGetFullXid(XLogReaderState *record);
-#endif
-
 extern bool RestoreBlockImage(XLogReaderState *record, uint8 block_id, cha=
r *page);
 extern char *XLogRecGetBlockData(XLogReaderState *record, uint8 block_id, =
Size *len);
 extern void XLogRecGetBlockTag(XLogReaderState *record, uint8 block_id,
diff --git a/src/include/storage/standby.h b/src/include/storage/standby.h
index 24e2f5082b..995d3c365d 100644
--- a/src/include/storage/standby.h
+++ b/src/include/storage/standby.h
@@ -14,6 +14,7 @@
 #ifndef STANDBY_H
 #define STANDBY_H
=20
+#include "access/transam.h"
 #include "datatype/timestamp.h"
 #include "storage/lock.h"
 #include "storage/procsignal.h"
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/t=
ransam/xlogreader.c
index 3596af0617..12d5175dc3 100644
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -2157,37 +2157,3 @@ RestoreBlockImage(XLogReaderState *record, uint8 blo=
ck_id, char *page)
=20
 	return true;
 }
-
-#ifndef FRONTEND
-
-/*
- * Extract the FullTransactionId from a WAL record.
- */
-FullTransactionId
-XLogRecGetFullXid(XLogReaderState *record)
-{
-	TransactionId xid,
-				next_xid;
-	uint32		epoch;
-
-	/*
-	 * This function is only safe during replay, because it depends on the
-	 * replay state.  See AdvanceNextFullTransactionIdPastXid() for more.
-	 */
-	Assert(AmStartupProcess() || !IsUnderPostmaster);
-
-	xid =3D XLogRecGetXid(record);
-	next_xid =3D XidFromFullTransactionId(TransamVariables->nextXid);
-	epoch =3D EpochFromFullTransactionId(TransamVariables->nextXid);
-
-	/*
-	 * If xid is numerically greater than next_xid, it has to be from the last
-	 * epoch.
-	 */
-	if (unlikely(xid > next_xid))
-		--epoch;
-
-	return FullTransactionIdFromEpochAndXid(epoch, xid);
-}
-
-#endif
--=20
2.47.1


--HFly0Z25TtFftSr2--

--bprFPq7MP7Et3G/w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeJ5AEACgkQnvQgOdby
QH2/1w/+I0CZcUQ3AQrfPJ//N2ZdiDyFmMAr25qsx29Lx+PuRhnokt37Wrdov9m6
dI8WBa6lFdCdU62niulYPPWFrnvzAnE974PfSW3AAjWYnFuwJVgLQE5vfwT2dBz4
2jnhOdHGHzt7V22W9mp5f4V8hxLozovnUA7Dq0eyre4V3l099m3gUctHdQurE7sv
HwI4hHXUhsgEz7K5YI9HhVT2x69XqgbSUrHwyLQ30yE+iu26yFeX60vX/8MII8n2
10Vr+urrj44a9NwNfZoLXkZafUjSGO/U2RGB/org8cVeuW1rDBr1RP2NyEEHBY3m
TDvwXUQ90seGZZl4w4EM482aQtA0nYrcpbQGyKCuxAfLhB5h6m00qdS0mnYDlcu/
xBovB8N0ZPIsq6QuUGcTlC5dk6nkW6dGUcxtclzdYOZ7hHHXtjMdCFk97Fr6C0Uq
bMVFhuzqcaJufVaJjBXDx7HOvFpQDIZiXxncxIC/yMdKFMZsVxcNT6eS0lZATf/U
FbnkVVzPKieZf+q6fW/QxLMK6TtL1fEMKkflBMDnr5APWzVOMOCo6g7MDv3AhjOu
cWKIGJF4XVBXI6MaBo2Fmi6xAHbdDLnK8zgVzb6INV2t2Q8Z5U5dMkJDlMMSxSAn
7wqur1ifp/pJF8yEUQxqMOjS4ksXAm9RpAeLMqGqiWhcCZUEIDs=
=0Rrl
-----END PGP SIGNATURE-----

--bprFPq7MP7Et3G/w--