Date: Fri, 17 Jan 2025 06:06:35 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Z4nza3pgLpD+rmrE@ip-10-97-1-34.eu-west-3.compute.internal>
References: <Z2FAyFSg-lRGFZio@paquier.xyz>
 <Z2FF6ScWef9yIrJL@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2JWUaY8AHBs99yp@paquier.xyz>
 <Z2KDy56Ls4nBl1Y8@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z2OfYh3QJ7M5D0i-@paquier.xyz>
 <CAN55FZ0ZQTf-D+5Rup4H6zp+n3E2EuonYuzTiPkp=1GhesZU_A@mail.gmail.com>
 <Z4dyHHxGfGK7bGjd@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z4d_eggsxtBEdJAG@paquier.xyz>
 <66efowskppsns35v5u2m7k4sdnl7yoz5bo64tdjwq7r5lhplrz@y7dme5xwh2r5>
 <Z4mfYkpzm5Fe44lZ@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z4mfYkpzm5Fe44lZ@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z4nza3pgLpD%2BrmrE%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Fri, Jan 17, 2025 at 09:08:02AM +0900, Michael Paquier wrote:
> Anyway, let's just switch pgstat_backend.c so as we use a static
> PgStat_BackendPending (pending name) to store the pending IO stats
> that could be reused for also the WAL bits.  It does not seem that
> complicated as far as I can see, removing pgstat_prep_backend_pending
> and changing pgstat_flush_backend_entry_io to use the static pending
> data.  The patch set posted here is doing that within its
> pgstat_flush_backend_entry_wal():
> https://www.postgresql.org/message-id/Z4DrFhdlO6Xf13Xd@ip-10-97-1-34.eu-west-3.compute.internal
> 
> I could tweak that around the beginning of next week with a proposal
> of patch.  Bertrand, perhaps you'd prefer hack on this one?

Yeah, I had in mind to work on it (in the exact same line as you are describing
above). I'll work on it.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com