public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: [email protected]
Subject: Re: Remove XLogRecGetFullXid() in xlogreader.c?
Date: Fri, 17 Jan 2025 09:39:16 -0600
Message-ID: <Z4p5pEWtZ9dbn7aE@nathan> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

(I've added Thomas Munro to the thread.)

On Fri, Jan 17, 2025 at 02:00:49PM +0900, Michael Paquier wrote:
> XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019,
> but as far as I can see this has never been used in the code and this
> is used nowhere in the core code.
> 
> I have looked at Debian's codesearch and also looked at traces of it
> on github without seeing it being used anywhere.  Knowing that this
> was originally intended for a hypothetical undo log patch back then,
> for which no work has been done for years, is there any point in
> keeping this function in core?
> 
> This issue has been raised on a separate thread, where Noah has sent a
> patch to consolidate a bit some epoch calculations for
> FullTransactionIds, around here:
> https://www.postgresql.org/message-id/[email protected]
> 
> Removing it would have the benefit to do a bit less refactoring for
> some of the work of the other thread, and this removes all traces of
> -DFRONTEND in xlogreader.h.  ;)

Seems reasonable to me.  I think the counterargument is that folks
developing new AMs should use this [0], but if no such users have
materialized in several years, then maybe that's no longer a concern.

[0] https://postgr.es/m/CA%2BhUKG%2BmLmuDjMi6o1dxkKvGRL56Y2Rz%2BiXAcrZV03G9ZuFQ8Q%40mail.gmail.com

-- 
nathan

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Remove XLogRecGetFullXid() in xlogreader.c?
  In-Reply-To: <Z4p5pEWtZ9dbn7aE@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox