Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 22 Jan 2025 14:50:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard
 to read.
Message-ID: <Z5CHN6WajoZP6Rqz@paquier.xyz>
References: <0f5256ec-d63e-4e0f-9b71-750a7a4e5c01@dunslane.net>
 <651128.1734017715@sss.pgh.pa.us>
 <87jzc46d8u.fsf@wibble.ilmari.org>
 <5f41d6c6-1cbb-494d-a5c4-3c449fc4e9ad@dunslane.net>
 <105f432a-6b0b-42d4-9061-65d263279be7@app.fastmail.com>
 <CAHut+PuD0aQfjAN0q_7FpdNdSEdrhONpTsb0tQi5ZEtZHj6bKg@mail.gmail.com>
 <87ldv542fk.fsf@wibble.ilmari.org>
 <CAHut+PvKrQXY7kM8ct=HC9xYPC6yhdJWnvCgijtgxmO-mus8uQ@mail.gmail.com>
 <Z49PYgXnbyU6IiEe@paquier.xyz>
 <87frlc45gg.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GJd04sdspUA9t6u7"
Content-Disposition: inline
In-Reply-To: <87frlc45gg.fsf@wibble.ilmari.org>
Archived-At: <https://www.postgresql.org/message-id/Z5CHN6WajoZP6Rqz%40paquier.xyz>
Precedence: bulk


--GJd04sdspUA9t6u7
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 21, 2025 at 02:17:03PM +0000, Dagfinn Ilmari Manns=E5ker wrote:
> Thanks again for reviewing this monster patch.

+$node->command_checks_all(
+   [ 'pg_amcheck', '--exclude-user' =3D> 'no_such_user', 'postgres' ],

Extra error spotted here with s/--exclude-user/--username/.

The double --verbose for test 'run pg_createsubscriber on node S' is
intentional, as mentioned by Euler.  Fixed this one by making the two
--verbose be side-by-side, and added a comment to document the
intention.

Perhaps pg_resetwal/t/001_basic.pl should also use more long option
names?  Note that there are a few more under "Locale provider
tests" in the initdb tests.  I've left that as a follow-up thing,
that was already a lot..

Found some more inconsistencies with the ordering of the options, like
a few start commands with pg_ctl in the recovery tests.  I've
maintained some consistency here, even if your patch was OK.
--
Michael

--GJd04sdspUA9t6u7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeQhzcACgkQnvQgOdby
QH3cMBAAlsKmvj/j/btu0peJfMyHSAcfygvlws1VhAHujan/CMgnDlsCas3jZDAt
0uSKl+AmwV4j+PXYkq4kpmDfj6uA7STb2HeArSfJwY0BoU/Lx0I/j64HIA/xMDNd
wa9msIsvNeR3f44k31ZcajeAe3Euygynkex84pHRLSq8nkGBJhWfScONgUVqDlCR
KNv+Oh5BbMYerPrtxKXytk7vD4Gi9F7oh0tp0BVRjUEYgvPFN4l6lZJwTByCirEQ
L4zwYSnzxQL1GCi+/yiR9czeKoSZJpeGTK6TY09n3RiKMcetAfTKEtm1AYY6POoI
b7Sji5NAJfR7/vF+UKy6U7zYewuEuwE6dcChyI8t8wLpIr+RYky778NG0rd50V4D
8wCAmU6EdqdPEm7iosJzLzyJPfrfizuF0dzEwDRETP4hCfsrhrftDYlYGO7NhJg8
QGQrICnN1xNq8mdUgdWgVg6Vo/VgtaZ4BnwvQToyV0td8X2PZ+OQMgSq0nl60Wgb
JtAVnLsI58qLVcpGofvkbWxNUePtgOJoaHwz8bilOB28ZY+C35GK7bLXerw74n2o
RsUg00fwRnAItRbEXAH1GC/zme0pzxQXzU1ihvRmE63tDJUEkPBcFCT4d8QKgsRV
0GEr5xWxcBRuhypvxXHUkFohmmXJ7aQAeE2WczMBGl/XvwWYEkA=
=R1O9
-----END PGP SIGNATURE-----

--GJd04sdspUA9t6u7--