Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 24 Jan 2025 15:22:48 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard
 to read.
Message-ID: <Z5MxuDQBr_S8YNwW@paquier.xyz>
References: <87jzc46d8u.fsf@wibble.ilmari.org>
 <5f41d6c6-1cbb-494d-a5c4-3c449fc4e9ad@dunslane.net>
 <105f432a-6b0b-42d4-9061-65d263279be7@app.fastmail.com>
 <CAHut+PuD0aQfjAN0q_7FpdNdSEdrhONpTsb0tQi5ZEtZHj6bKg@mail.gmail.com>
 <87ldv542fk.fsf@wibble.ilmari.org>
 <CAHut+PvKrQXY7kM8ct=HC9xYPC6yhdJWnvCgijtgxmO-mus8uQ@mail.gmail.com>
 <Z49PYgXnbyU6IiEe@paquier.xyz>
 <87frlc45gg.fsf@wibble.ilmari.org>
 <Z5CHN6WajoZP6Rqz@paquier.xyz>
 <878qr146ra.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3zJamhOxQOaPOO+D"
Content-Disposition: inline
In-Reply-To: <878qr146ra.fsf@wibble.ilmari.org>
Archived-At: <https://www.postgresql.org/message-id/Z5MxuDQBr_S8YNwW%40paquier.xyz>
Precedence: bulk


--3zJamhOxQOaPOO+D
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 23, 2025 at 08:25:45PM +0000, Dagfinn Ilmari Manns=E5ker wrote:
> Here's a patch for that.

Thanks.  I had a bit of time today and applied it.

-	'multiple -c options with different case');
+	'multiple ---set options with different case');

This description had one character it did not need.

I was looking at the rest of the tree with the following command, and
there still more that could be switched (not surprising):
git grep "'\-[a-z]" -- *.pl

Perhaps not all of them are worth doing, but I'd surely welcome the
pg_upgrade part.  If more work is done, let's move to a separate
thread; a lot of work has been done here already.
--
Michael

--3zJamhOxQOaPOO+D
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeTMbgACgkQnvQgOdby
QH1N9BAAoMIKm+yHUUVPR8kQM987RPdFaAdtWxAJYKxI7M2vZ0Lcv2Wap8DkX6O4
41k2FbLSSDoYapYGiAZFtFwYVsbtxHbtGRtzC1IvC8CYUnBtq2ODlxNeEaRcPpFG
pwCKDUY6i0IxIUZ+cPsK9DpWQkkBcX7bnXnD0Z7zNjRcDuHs7Q/FDPcmF4//juL5
93I2EBSZTs5uR8gt4fRpUGa56iryT1xlXtZN71RJn0e11ff/Wv2tNnmsUWFzdsvV
ChIszcjgXmXwpLTCSwgxN7+GDUus7chjp29ScVf+PShoPjyTF2yf9AaylsSLExSy
ONq8fM/Bv34L4r/SbR9v5uaTOxrjTxd7JwL9saEyHGxr3/ltnDujT32SUurW3qS/
7upw9Dc0MNCIW18B85byevLcI6CYMmfzlGNV7OCaZS+m9nusBC6KPSTIqzF+E9I0
7Uf7rKNWp1fcjnSCYG1dPLqxja+lO+QwjsYjzXEkMOPgyynYamrrHNgtp4otCxpw
9jikfk8d3oxQbjPFPt0hWqRcLgSGpitglvkJWUbI3NjLVGymbT3TB+fZ0KHmfWRQ
B6G1P0C5W6+TbHiNIs57oBlJjwJlGGEnuczPpyPckePC3+BHbEvfyjMW98gMJok9
tLECP48dW4GRgZdU3550m2QvhljvcsDi33/k5KueG/5UgM6USKA=
=AJwr
-----END PGP SIGNATURE-----

--3zJamhOxQOaPOO+D--