Date: Sat, 25 Jan 2025 16:07:27 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: "Chiranmoy.Bhattacharya@fujitsu.com" <Chiranmoy.Bhattacharya@fujitsu.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>,
	John Naylor <johncnaylorls@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	"Devanga.Susmitha@fujitsu.com" <Devanga.Susmitha@fujitsu.com>,
	"Ragesh.Hajela@fujitsu.com" <Ragesh.Hajela@fujitsu.com>
Subject: Re: [PATCH] Hex-coding optimizations using SVE on ARM.
Message-ID: <Z5Vgn4oKWByqoxmq@nathan>
References: <CANWCAZZvXuJMgqMN4u068Yqa19CEjS31tQKZp_qFFFbgYfaXqQ@mail.gmail.com>
 <622082.1736834344@sss.pgh.pa.us>
 <Z4aXj_fJYCQ6GBbC@nathan>
 <CANWCAZYNtrphdWSEakFbGrJZtjkFvvo8BB6nh5AGRiTfUu47Og@mail.gmail.com>
 <1194263.1736925288@sss.pgh.pa.us>
 <CANWCAZaq-hHGzEE9u=+ed3czdn6WUQdmGpmUpBiT7p+wNsOS+A@mail.gmail.com>
 <CAApHDvpJr7r0n6TY_0psumA1uLy7+nmdq==L3jjDT-RYPMoHRw@mail.gmail.com>
 <1519827.1736990839@sss.pgh.pa.us>
 <Z4qQMS8EtYzN-eno@nathan>
 <OSBPR01MB2664A733AFB69AB1A7A43CC297E12@OSBPR01MB2664.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OSBPR01MB2664A733AFB69AB1A7A43CC297E12@OSBPR01MB2664.jpnprd01.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/Z5Vgn4oKWByqoxmq%40nathan>
Precedence: bulk

On Wed, Jan 22, 2025 at 10:58:09AM +0000, Chiranmoy.Bhattacharya@fujitsu.com wrote:
>> The functions that test the length before potentially calling a function
>> pointer should probably be inlined (see pg_popcount() in pg_bitutils.h).
>> I wouldn't be surprised if some compilers are inlining this stuff
>> already, but it's probably worth being explicit about it.
> 
> Should we implement an inline function in "utils/builtins.h", similar to
> pg_popcount()? Currently, we have not modified the header file, everything
> is statically implemented in encode.c.

Yeah, that's what I'm currently thinking we should do.

-- 
nathan