Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tiKZl-00EbRr-LH
	for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Feb 2025 21:47:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tiKZj-00F8lh-MU
	for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Feb 2025 21:47:20 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1tiKZj-00F8lZ-CX
	for pgsql-hackers@lists.postgresql.org; Wed, 12 Feb 2025 21:47:20 +0000
Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <nathandbossart@gmail.com>)
	id 1tiKZi-000T6l-1O
	for pgsql-hackers@lists.postgresql.org;
	Wed, 12 Feb 2025 21:47:19 +0000
Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-3d15bacddbdso1193535ab.1
        for <pgsql-hackers@lists.postgresql.org>; Wed, 12 Feb 2025 13:47:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1739396837; x=1740001637; darn=lists.postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=sBBnp75oBGNiOBbtJTP5cW5vJETsWmN9YwfDm/lQ2Hk=;
        b=KkdblRPllMFtN7B1sTPmP1uDd8Hdd4hYu4HHoZVwHOHSbKMNbU5nHyO9W8iBn9b/Yh
         DXzyu2nZamyOSZu2ckMVmQMLApC/6BurKktYU4NN3elMy6qorl+Fp+D3C+H+qXqDmA/M
         71pmzE7a6wpUO5+5AZMtRrmXNslqCtrouBofMh3WcyjyYMj2yS7ftcFVpss05BfbhdfO
         bU6OVwu3EtBeaX+JAy67JkuVbV7s5/6Ms07jkYBMoaGV4qZfERYTIvftM7arldunhBg+
         E+MZiWasImY8HGxh/dS5XKe3qEZ8TfDCMLIGOex8slxfBegLlYTl+LiPxTnQKtyr04MS
         ImJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1739396837; x=1740001637;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=sBBnp75oBGNiOBbtJTP5cW5vJETsWmN9YwfDm/lQ2Hk=;
        b=i/ePsbhIVPsHs0NMUeuRWSz8PJriZuZmud2rUxXUUQH3KpN9F+K4Pe4bpu4abRWo8t
         KCJUPUXJ/k6whZrCdmXC7EQrV2Thc0JwUHa/n3nKN76be/1wVMWrcT0inUNckXXlRTEA
         Uzvg7NKnY7ThT8gY5gUvvONKE2+BC3ubBTJcIQ0YJbtvUTBz8FLxgPrpZK2jLmk7Hztq
         ZTVZnQukzLCeuvBWPEwWFEJr9d61EIkLYOkwhadklBrok3H4+wNJ3g6te93ixOIcGOIl
         K9YFVfeU2zxXfJWcJ741lApE3CVXtOVzLiPGGwyGOcpYqGMPgD4E0jCWispvafsqA54G
         BmXQ==
X-Forwarded-Encrypted: i=1; AJvYcCUoFe/wLiNZ+xupqTVangbixnefyGADsIgiQ0vSu0N46KWC/RjKc0kbyM4a73JeocL+b0NzMr82eR2bIe2A@lists.postgresql.org
X-Gm-Message-State: AOJu0Yx9asbn7y+rQRYfu+E/P71m3TkPUBIaGvi5+hvrspA2jTIE5kOm
	qj/Zklfr3RGAQADJKMK94s4qIyY/CqwEfURLqmBru9CiLRH5qDHe
X-Gm-Gg: ASbGncuo2NRgclzABJ2CwI3pP5f9XlZ/Ub4WFX7LkNFXuRRw0p8e6eMOP3RA2MymgZ/
	03d4PVd+8qxNdTMcV3Z+bAnaOcvwCHt+Oq/nQ+xnJIR7I+vCJWA7WGea5/bzYU9RH9rV665gjMc
	dqccVw7bA41HgNQHlzHBzlMDXfRQ/oGEo/Dbr6gjnRFB/YMdQzh+XNe0z5H7FXvr95zUpSxtpwD
	JuOyjhqe4e/1WPZLZWTN6yL1RQ2KXCI9gFvc3RRZJZ1jnJwF8ZjhGS5lE7WlHctMtNxADmWLBnE
	k0x+Ety0d09tLA8sy0mVhnXk9RLfhjl9dSUyIzOowfmx45DTNCZz92SCRJGUS9oSqGOv5uknoq1
	v0P2zEQ==
X-Google-Smtp-Source: AGHT+IHD5fS2d3oXDTqzer9A02M9yM83TlRbuUAQl1DMlRJHihof9SPwouhNR/OHT2Vo7tty6JgwcQ==
X-Received: by 2002:a05:6e02:1987:b0:3cf:bb11:a3a4 with SMTP id e9e14a558f8ab-3d17bfddc67mr45877375ab.15.1739396837638;
        Wed, 12 Feb 2025 13:47:17 -0800 (PST)
Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ed0d18ac31sm1027685173.144.2025.02.12.13.47.15
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 12 Feb 2025 13:47:17 -0800 (PST)
Date: Wed, 12 Feb 2025 15:47:14 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Unneeded volatile qualifier in fmgr.c
Message-ID: <Z60W4ub-xUE34qjY@nathan>
References: <Z6xbAgXKY2L-3d5Q@jrouhaud>
 <Z6xevtT9vDJA2tcX@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z6zAXAKSqQHOwqyE@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z6zAXAKSqQHOwqyE@nathan>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/Z60W4ub-xUE34qjY%40nathan>
Precedence: bulk

On Wed, Feb 12, 2025 at 09:38:04AM -0600, Nathan Bossart wrote:
> In any case, I don't see a problem with removing "volatile" now, so I'll
> plan on committing this later today if there are no objections.

Committed.

-- 
nathan