Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiM8I-00EwtM-7V for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Feb 2025 23:27:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tiM8F-00GNDR-U4 for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Feb 2025 23:27:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiM8F-00GNDI-KZ for pgsql-hackers@lists.postgresql.org; Wed, 12 Feb 2025 23:27:04 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tiM8E-000TuS-1x for pgsql-hackers@lists.postgresql.org; Wed, 12 Feb 2025 23:27:03 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-21f6022c2c3so24578255ad.0 for ; Wed, 12 Feb 2025 15:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739402821; x=1740007621; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nKIt/rzK3IFOQYztckF20yxykPGXdsGYa7ZJuFrdk6o=; b=nrM84U107CFqBx4XZms1mv6FTmWyORKP8tV4FPyF4hm3t7K3yOsWMjDEDW9Ko9Kaqq lxJGh4ZhdSucxTuGWiQnucoiFREEtlN6UVam7gFf/NszJLJkAzQ54caaUTjPr9iEBx3s p94KhGs2nGOUjfYDRZc269QW5GCubkzGQsDwGL0Xhr5g1ETs73+SnQtFD8kvpVIgv8ZK YmUJclg/hctysBz1pq/TnrhzUQZCI9OwMh+Yi2btAH7XeznQSA28nEfxrYZ+2lENj/I0 xMzau6PPCHU1qu69qcgbLYwoX0OC27YvNJKVBm+Uj8NxhRqn8KI57HF69vxauEepbXdN weBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739402821; x=1740007621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nKIt/rzK3IFOQYztckF20yxykPGXdsGYa7ZJuFrdk6o=; b=oBkyk3X1j3cul+uRmmSF+P6PrfCxc9NOua9u2VyPvni7s09RCN7ZFvUO3DMJQxSvfR rzkczMFbC9mkHk5AveBRXvtse8we7eD+mEVMpSJ1GLFaa3U0Onbx6CySWrZhLeDYGxbm ESoybAWP3ihNHA3Ef5nnulDOGIy03oPQCvhqbXToMqXlLG7NumlFyqYcxd4qGyELGxxr 4WqsFwod37RdyPeUG/Zm+WF2x5pYUBnznEhOyUyL88nOQjnPLdji83Nl3W67Jee6tirs yhzFx6ZCyO3UQsJRZxkqJiIXdlFbqGXq8bfBly5Oeqh3myUbU23fzsg4eff2wa9HK1uO F9hA== X-Forwarded-Encrypted: i=1; AJvYcCXZyj1QmmJCuTIDHalMDxXXQ5fgx0soCyq7kANCqM1cDV+yBA/d+6qouQUaP8xABwlP73lnLhctFvqPPJPY@lists.postgresql.org X-Gm-Message-State: AOJu0YwaXIm6Ti9ko2azuKxe8MD3hhCg4W+JCGhb7NETS7Gn+P3rCgy+ AWLtzXv9gJzvBbGAm6q6aGq+slH9Rw102f2JVr5K+c2XExrcVahG X-Gm-Gg: ASbGncto0LYNyBebuzmCXEklwp999lfUvCxgqjsPGLpyqvvnDZ0mLYAIHP1wUJbmZYI v4b7/5c/Sh624x3n8QNNZ9df0Z+60CjI22CjYr+1CMsOhwLlBLDRmBSRJaRuq/Q+cjB3kazbtNN PbiS9r5skFJmlluMA39rV14v/vnzKx+mYHCjIJPvCgWqi16wgCgJLfqtd7JQbHXzdN3aq4WiLsC +Y+j6exemVilyJ8d5GTogQcjeUlf1JRYNY9xsuWqcpv9VbwDeXeCWTo2VoGIYk74g8ls0Dj2vyz /ga1JXE= X-Google-Smtp-Source: AGHT+IGWtkFWyskd75LjlA04/NwOvpSOVh7+vH+ix13Sb37zH5TYTZSNfstzqGkczoQ+bKrhPlW1Dw== X-Received: by 2002:a05:6a20:914a:b0:1ee:644f:257c with SMTP id adf61e73a8af0-1ee6c5e1afdmr1218463637.2.1739402821296; Wed, 12 Feb 2025 15:27:01 -0800 (PST) Received: from jrouhaud ([115.43.41.38]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-adb57c5e01asm7712a12.1.2025.02.12.15.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 15:27:00 -0800 (PST) Date: Thu, 13 Feb 2025 07:26:53 +0800 From: Julien Rouhaud To: Nathan Bossart Cc: Bertrand Drouvot , pgsql-hackers@lists.postgresql.org Subject: Re: Unneeded volatile qualifier in fmgr.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Feb 12, 2025 at 03:47:14PM -0600, Nathan Bossart wrote: > On Wed, Feb 12, 2025 at 09:38:04AM -0600, Nathan Bossart wrote: > > In any case, I don't see a problem with removing "volatile" now, so I'll > > plan on committing this later today if there are no objections. > > Committed. Thanks.