Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 13 Feb 2025 13:50:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Euler Taveira <euler@eulerto.com>,
	"ranier.vf@gmail.com" <ranier.vf@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Small memory fixes for pg_createsubcriber
Message-ID: <Z616FUBfX5uRYsOc@paquier.xyz>
References: <CAEudQAp=AW5dJXrGLbC_aZg_9nOo=42W7uLDRONFQE-gcgnkgQ@mail.gmail.com>
 <68d6d810-4ef1-4f62-b47f-89b21501249b@app.fastmail.com>
 <obqvpv4yx57lbnfiqvy4pmnfi2l5wn6xzoq2ftytxa426pa226@2sc46frt5xtb>
 <3337507.1739376124@sss.pgh.pa.us>
 <xseczrku4nm3p4rujapxiiuttpqrpagkbwrr2nlbnmwemh525y@3he54emhpqha>
 <Z601RQxTmIUohdkV@paquier.xyz>
 <3490963.1739405311@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="UOLEDxfCOHLeIiZF"
Content-Disposition: inline
In-Reply-To: <3490963.1739405311@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z616FUBfX5uRYsOc%40paquier.xyz>
Precedence: bulk


--UOLEDxfCOHLeIiZF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 12, 2025 at 07:08:31PM -0500, Tom Lane wrote:
> I spent a little time earlier today seeing what I could do with the
> use-dmalloc patch I posted earlier.  It turns out you can get through
> initdb after s/free/PQfreemem/ in just two places, and then the
> backend works fine.  But psql is a frickin' disaster --- there's
> free's of strings made with PQExpBuffer all over its backslash-command
> handling, and no easy way to clean it up.  Maybe other clients will
> be less of a mess, but I'm not betting on that.

Hmm.  Okay.  It sounds like it would be better to group everything
that has been pointed together towards what should be a more generic
solution than what I have posted.  So I am holding on touching
anything.
--
Michael

--UOLEDxfCOHLeIiZF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmetehUACgkQnvQgOdby
QH06MA//XVpjbbKz8/c76wIUZnIMdSbxzbdLrvCvyK9nHWsximl6MA2p7lruRawe
bvjBQySte/wgjEFPQcr3C9qexGXphWWThKbbPj41ll73m6IFn/7K+hCejr6tD6i9
/QB84UVK8/MROFE6ZgAwlSO6bx/hFZac4oqywRUaPSzici59fe6bVdQUQTj+Vq8z
R0vcgWEZeFudNXwnHK29CijLyEeYKLNYxbysAYo2B/45zLmFfi90AF8ryd9xBOhs
af6ZQPrn3O9jXacBVZWEP8aOEnT5v3kA4PUjB7gPjhlhw/QDi5lCqqeKKK1voQJ7
sv9laSMvq3pMZmQkvmYAYy/kHWOMfsSVwsvbgFrczumO1kVs/IzH7K0fio0W1Ikr
eoEBefjzTw6aBBHtCBUbRn4rsVyS9L6nAEI+hJcwB7HP+VLLLa+n7FVZOwGdS5wK
2kaIJxN0F541GVejwG2A0wnhj56i6y/5GTNTPdg2fxYnWrmZ3k86oKdszylmv+Zz
3ow5AU/XSQCb3QI7TX8D+pbpe4QvNB50JPmfgmuufDrXzibPZOjnH/QhUXfUl+0w
tVDBLMggT7StVV/ni+I+GUHZeAeGKodbb4TeQguQu1v0bx6TJP7tow/F5CA0qNJr
9sGUYDkChgCnvfwh0QKz467ywXiXBg6FSPHXWArer1uYgAkba8A=
=dYx7
-----END PGP SIGNATURE-----

--UOLEDxfCOHLeIiZF--