Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tihpT-001NcK-E2
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 22:37:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tihpQ-00FLnN-M0
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 22:37:05 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1tihpQ-00FLnE-CQ
	for pgsql-hackers@lists.postgresql.org; Thu, 13 Feb 2025 22:37:05 +0000
Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <nathandbossart@gmail.com>)
	id 1tihpP-000h8a-05
	for pgsql-hackers@lists.postgresql.org;
	Thu, 13 Feb 2025 22:37:04 +0000
Received: by mail-io1-xd2e.google.com with SMTP id
 ca18e2360f4ac-8551c57cb8aso25452739f.3
        for <pgsql-hackers@lists.postgresql.org>;
 Thu, 13 Feb 2025 14:37:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1739486221; x=1740091021;
 darn=lists.postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=wlZOpgiIAFIdtsT1J/nnTgnCNckGTeYjSPHfz3yH+8A=;
        b=eFxusBpqjPoW3YxSKsXr0rUftfAsBOOTTdKr81iCZPMeesdZERHaGKmdnjnPDs9IYT
         9xdBejj2p7CoFvFyscDkCvKX1h+9mmrrC5ifcOXx79sPsD6h6OyYFlTXWD3GkUhnCVpR
         cZuREBN4S3AjbeqFVVbKmrMdn0SmqaOweOzSGdSEzLdJmQXcb85c5aP7vda5VXMSps8e
         aZuvockQu8CuChDFN4ZCCEAXS4SCXSi5jQLIKz2+qsmD415Y2oXIbJF+cAATr9/pNsTQ
         FWVxqjj3BN7WjOhH+1VU21oJzE0nH+B8+3cx+ZY/RxvYBkkLCarlq7wKde90ftkX0dWI
         Ic5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1739486221; x=1740091021;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=wlZOpgiIAFIdtsT1J/nnTgnCNckGTeYjSPHfz3yH+8A=;
        b=nQby4fa5TMURiI4W8L+Nh8HtGxQ4BW4i/38n4xBooN2B7+Kl6Vf+2J8Wos3m8gWw2K
         ISB9ynA5FLx6NHDTEQp6xNJEY7iG5MILmFnEp2leTofpqGqt9vPkR4/H1xT9ayeM904W
         fQqzPp5DJ76W5mG3cCVc/9F03TxsdRYfx0wKo8PRbjOkV3ERwg6p6z79Fq4RSvTZsj1g
         DIqdQIAT0kW/mXFbuf9NMVM+nJ2AAgs7oC2Iv7IOSmgrHFBWl9IaQ7t6sMUSlT176J8a
         QrLRy26OtyvDde/d4028nLh8h6zSC/xzIsCk+KGKJHrI0bsFAMffMuyZ9qOUYYrmQVyu
         Fs0Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCW4NmI+Qu++TwxNxvhbXAqUpY/ISkJiOc2CLpcoqi8tOHJHSm1VOfFNKzlivNQsS14MnFiBy4Q9SJiUOmTm@lists.postgresql.org
X-Gm-Message-State: AOJu0YwDje+Wcg+X5PE9oZtszfFxo0SMZif8rl5FEiSeAldyvqRyBQsz
	uOYZmsYue6u0Qr1xZzz6+vNdOwKIo+GsZKwXV/RrkzHLGXbNolx9XgHzOA==
X-Gm-Gg: ASbGncsli3/FnytOJV3zBOrQZYg8JtotxOaGTgQlSKr2OGz0KHY+ZhC4nsprsVfno/f
	8l6S1cunqOXwiMFCJvuCfosmzNEnLWuMHw2UXLMRQibphHSaFKW0r+lIEnQGXlAbFga6eosR0UJ
	iqbrFOMdhavZbWTdrXUPNkgCwN69vg6K0P8O4NGBHrRriPT0NNa+iI/5wmJaZy+tvfs7wcR3v+C
	jIoGr2s5TgV1M+0CsGu0XZaTMmL3xluviwMSNRw2q+s0m3IwrsyhaBTMSIQaKZPnEZB5IC2t7ik
	P4lDorKC/F2vdqgPTfKa8G93W5v0PgRBpaZ93Qvqbwzhnp9rvgIxCYVSs0cfPNtFuWBtywFt3tg
	Z8gaEwA==
X-Google-Smtp-Source: 
 AGHT+IEWlF3nHpVXa5qPhN2MfhKbKGqKqvjBGKY2YbiRvCtnbi2gmVDAvKyNPc6uGYaPukb8UD05zw==
X-Received: by 2002:a05:6e02:3706:b0:3d0:4700:db18 with SMTP id
 e9e14a558f8ab-3d18c3293eamr49776015ab.20.1739486221300;
        Thu, 13 Feb 2025 14:37:01 -0800 (PST)
Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net.
 [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id
 e9e14a558f8ab-3d18f9a8a9csm4175305ab.14.2025.02.13.14.37.00
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 13 Feb 2025 14:37:00 -0800 (PST)
Date: Thu, 13 Feb 2025 16:36:58 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg17.3 PQescapeIdentifier() ignores len
Message-ID: <Z650CpBakUdjdRp2@nathan>
References: <Z64jD3u46gObCo1p@pryzbyj2023>
 <3718360.1739473209@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3718360.1739473209@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/Z650CpBakUdjdRp2%40nathan>
Precedence: bulk

On Thu, Feb 13, 2025 at 02:00:09PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
>> The fprintf suggests that since 5dc1e42b4 PQescapeIdentifier ignores its len.
> 
> Ugh, yes.  Need something like the attached.

Your patch looks right to me.

-- 
nathan