Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tfOdA-0027Hq-KL for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Feb 2025 19:30:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tfOd9-007cnB-LQ for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Feb 2025 19:30:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tfOd9-007cmw-9P for pgsql-hackers@lists.postgresql.org; Tue, 04 Feb 2025 19:30:43 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tfOd6-003B7H-2T for pgsql-hackers@postgresql.org; Tue, 04 Feb 2025 19:30:42 +0000 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-844e06e5d11so159047039f.0 for ; Tue, 04 Feb 2025 11:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738697440; x=1739302240; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hAQ8XnQxyO8z0uGj7VnueXXOxCZ2RjSrr523/ObIYYc=; b=IjtLqixrs4MG6IokMQG85fuT6sGitIk64fxJbOLUbmAJQw9AqCU110/B5Bls3lR3Vg +kmkAFOnEZLVT18pGapOgsjGB0NmxFAGhzZIsjly6b+YKiL8xFBYNuXzzkVJtdmqFuJy 1Dz1MJy2MFCQFDQgO9X8nDzJySr74JRfcpfKopjhnOa0f+WbxzwCIjs1kc3Q6wYLAecS PjiIaA1aVY5u5YC0vp+48gz5+45NQwzo7VEzS+1nbNSxIZ/r1Og4IBayHdFxGMJ5kv0r HnHPF7Nn3LJ2oDuT8IiKzFe8JPLSCwCm5sxX1X/9nIvXUjE60N6Q5TATPD7YObzoZ0RO UGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738697440; x=1739302240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hAQ8XnQxyO8z0uGj7VnueXXOxCZ2RjSrr523/ObIYYc=; b=EFKtGDlpsFQHibUlpSbQhgEEcUp8z1gA2reXDNOanoDZkY5J4pYSn9A2OCy0+7EEDS IUp2ourJvBShC+A6wSvQV6vOZSe0O9M4Ds3osHntwh5mRhxG/ySspxEcgXoNyLrryR8x qUDU2tzS1nFvuPcc9VoCOpcK9fZeOM5aFMcvcoeFu7hQylSl6aPMQtfyDoZaV39HJlL7 etz8LlJC+8NpltDkF7qELl3PmVsksvRb1PG6vQeV0Hu3P6Rd5BlBNk509fHZXKwnPVcf d29D5fT4HEOVu8mOHvMuhrHjtKKr9SiMxvFSmljvb2GsGypCzUqDbdNvqk0Hjb4kr6p7 lOBw== X-Gm-Message-State: AOJu0YznALDSXGAa756U1KrkI3I3Qae/ROj/TI1sI6GbUy/sQhuiZ7FW Xnw7vTKkI8J9euXlyl4XKn7qXG2R8kbEkrf+SRmJB7Hsguq1tO60fp51wg== X-Gm-Gg: ASbGncu31+ba2bFQpQr0FklLKShS3LqEPedjHMQ2Z1cY/gsZxt68k8J3Ncco7D/ri7O 4CRLcHz0wNLSfsViwO+SHRLZISxDiDhTjXw80+OOQoTWjbAbB1s0FvziEJWoJoajkoVuM+iVYpu ANU6xt8Zo1DWxY4wCjnIk59Xt/B8qp0rGeGrDFVXlbJeYQtEObJjTId0z9DSQ6c9zYT9SyrdLJn M1bxzvtKbVJvAuCSCASYa1t5m6TZx3Zh10yOf4mmc0KcHqwFqXwR45hJ6N/aDM8ZaIHo9tKPLnj ZZynv+bTdj6XScAWHjyJXXe7XUBYCoh9C5gyrWQDA1aq0+WVPOn3UYnrMFVFlr6CxKe0MTqbvs6 48EiRPw== X-Google-Smtp-Source: AGHT+IGkQf6yNhqq7c5cj6rM0oAoAmkP+SDoVThxcRDlM7zKLxyNFvLiPusv8AnOpi0CtbWzjTLJcg== X-Received: by 2002:a05:6602:6a46:b0:847:51e2:eac with SMTP id ca18e2360f4ac-854ea45e7d7mr25252139f.7.1738697440216; Tue, 04 Feb 2025 11:30:40 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ec745cb7edsm2837891173.59.2025.02.04.11.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 11:30:39 -0800 (PST) Date: Tue, 4 Feb 2025 13:30:38 -0600 From: Nathan Bossart To: Daniel Gustafsson Cc: PostgreSQL Hackers Subject: Re: add missing PQfinish() calls to vacuumdb Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Feb 04, 2025 at 05:51:28PM +0100, Daniel Gustafsson wrote: > No objections, I too prefer to do the right thing here. +1 on backpatching. Committed. Thanks for looking. -- nathan