Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Feb 2025 09:12:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Marko M <marko@pganalyze.com>
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a
 query
Message-ID: <Z6Ks3ta5089DXiPc@paquier.xyz>
References: <CAP53Pkyow59ajFMHGpmb1BK9WHDypaWtUsS_5DoYUEfsa_Hktg@mail.gmail.com>
 <Z5A__Yuy23aXqUad@paquier.xyz>
 <CAA5RZ0sUPPOpkRZD=Za83op2ngcPC7dp249vcHA-X5YS7p3n8Q@mail.gmail.com>
 <CAP53PkwuFbo3NkwZgxwNRMjMfqPEqidD-SggaoQ4ijotBVLJAA@mail.gmail.com>
 <Z5cDQJM9nnoXuStO@paquier.xyz>
 <Z5xTb5iBHVGns35R@paquier.xyz>
 <CAP53Pkw1QJHH9UDjkArS=XdAxtK7XWMpZLGHnVMDmhRTp_HYYw@mail.gmail.com>
 <Z5xgmgyV-wnzMpkO@paquier.xyz>
 <CAA5RZ0vM9AsEqvKued2drKZJ1opt3wbYaDbxGzi-khkNzwn7og@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6Xwpn9qNqLlCl205"
Content-Disposition: inline
In-Reply-To: <CAA5RZ0vM9AsEqvKued2drKZJ1opt3wbYaDbxGzi-khkNzwn7og@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z6Ks3ta5089DXiPc%40paquier.xyz>
Precedence: bulk


--6Xwpn9qNqLlCl205
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 04, 2025 at 05:14:48PM -0600, Sami Imseih wrote:
> Here are my high-level thoughts on this:
> 1. rename queryjumblefuncs.c to jumblefuncs.c

If these APIs are used for somethings else than Query structure, yes,
the renaming makes sense.

> 2. move the query jumbling related code to parser/analyze.c,
> since query jumbling occurs there during parsing.

Not sure about this one.  It depends on how much is changed.  As long
as everything related to the nodes stays in src/backend/nodes/,
perhaps that's OK.

> 3. Rewrite the comments in the new jumblefuncs.c to
> make it clear the intention of this infrastructure; that
> it is used to jumble nodes for query or plan trees.

Seems to me that this could be done before 2, as well.

> I can work on this if you agree.

I'd welcome an extra patch to rework a bit the format of the comments
for the Plan nodes, to ease the addition of pg_node_attr(), making any
proposed patches more readable.
--
Michael

--6Xwpn9qNqLlCl205
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmeirN4ACgkQnvQgOdby
QH2chg/+O/y5ziUEa6Az4EriZpcR8eagNOp25mO6LP7aYQOZ3R3YyHgJglg/BXWV
WdsO1W7NUziAvM1S/AMD6FlfdpLVDPC1gD+VULJ448B+4jrtDToucCJcZvJZG2V9
r7J5LZvViVLt+c8tk9Ex/gVxgSqcsZfBSns4e3eCWHMmHS1cUD1gPoedFYRQVvGl
9siYFHHC7zaTGetqD2oHR9rHNxu3ShwtggGgkH5IHZuD6FymLQ+jlP6sJgav12sl
LUW+r9xZGQyMK7qf8cqthoJGrb83nTdRHu9sGyj3LMZ3YSZc8Ck4dkKFsQkpGJSv
NqRvW5OZHyp8RwS+cBO60N9dDZGTxVWk6+nsqsAId/ToRwt4880mRz9pPgSR+Amw
oq1rbV/GScUEEFSeaIz0LJhfklxv0sNHiEpoB8qgvOg+PPZvkNudPjFMJg9NL0m6
ySbYBOkyVeozSIOlIvt+xIIPYWaT0QlFgiuEmOw/YM2r28hh0wLfVPqOo5UqJKPi
VsXTMHoDN0p/L7KBFZ/P+QChTQNauwdQKwOAdzAGvmtE/ghKaZS5crH9cNGaAEyZ
dlhapstY5uqxXI0PrPqHWt684XD0Q90526zVpqJH4JCTwedYSgqitqrHdv56zaTJ
gpz8WHopMlwvbU7LWLJ9Oxp9zE3tEE9MgcdjWL4oc0pTEalG1wU=
=hR+i
-----END PGP SIGNATURE-----

--6Xwpn9qNqLlCl205--