Date: Fri, 7 Feb 2025 11:57:12 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Tatsuo Ishii <ishii@postgresql.org>,
	pgsql-release@lists.postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
Message-ID: <Z6ZJeMold-CjtmR4@nathan>
References: <85fe426d-248a-47f7-8784-22af811ee572@oss.nttdata.com>
 <20241108.114713.484828673471024549.ishii@postgresql.org>
 <95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
 <20241125.083155.1820744655877715597.ishii@postgresql.org>
 <ffc99be5-e418-40ee-91d6-62c3deb42918@oss.nttdata.com>
 <4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb>
Archived-At: <https://www.postgresql.org/message-id/Z6ZJeMold-CjtmR4%40nathan>
Precedence: bulk

On Fri, Feb 07, 2025 at 12:28:16PM -0500, Andres Freund wrote:
> I just did pgbench -i 100 -q via ssh and noticed it was *way* slower than I
> expected.  Did it with debian's pgbench, no such issue.
> 
> It's due to this patch.
> 
> /srv/dev/build/m-opt/src/bin/pgbench/pgbench -i -s 10 -Idtg -h /tmp -q > /tmp/pgiu 2>&1
> 
> With HEAD:
> pgbench -i -s 10 -Idtg -h /tmp -q 2>&1|wc
> 1000114      52 1000448
> 
> With af35fe501af reverted:
> pgbench -i -s 10 -Idtg -h /tmp -q 2>&1|wc
>       6      52     340
> 
> Outputting that many lines to the terminal causes noticeable slowdowns even
> locally and make the terminal use a *lot* more cpu cycles.

Presumably we should only fputc(eol, stderr) when we actually fprintf()
above this point.

> Given the upcoming set of minor releases, I think it may be best for this this
> patch ought to be reverted for now.

+1, since we're nearing the freeze and this doesn't seem like a
particularly urgent bug fix.

-- 
nathan