Date: Fri, 7 Feb 2025 12:13:37 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Tatsuo Ishii <ishii@postgresql.org>,
	pgsql-release@lists.postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
Message-ID: <Z6ZNUejz0L0pxQY4@nathan>
References: <85fe426d-248a-47f7-8784-22af811ee572@oss.nttdata.com>
 <20241108.114713.484828673471024549.ishii@postgresql.org>
 <95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
 <20241125.083155.1820744655877715597.ishii@postgresql.org>
 <ffc99be5-e418-40ee-91d6-62c3deb42918@oss.nttdata.com>
 <4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb>
 <1456496.1738951118@sss.pgh.pa.us>
 <Z6ZK0LBTInOt7VWE@nathan>
 <1457693.1738951804@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457693.1738951804@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z6ZNUejz0L0pxQY4%40nathan>
Precedence: bulk

On Fri, Feb 07, 2025 at 01:10:04PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> Oops, I was already taking a look at this.  I figured it'd just be
>> something like the following, although maybe there's a more elegant way.
> 
> Well, the stuff with prev_chars really ought to be skipped as well.
> (Yeah, it's probably a no-op, but readers shouldn't have to figure
> that out.)
> 
> My thought was that duplicating the logic isn't so bad, as attached.

WFM!

-- 
nathan