Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 12 Feb 2025 10:59:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Lukas Fittl <lukas@fittl.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Marko M <marko@pganalyze.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a
 query
Message-ID: <Z6wAaGieBgd0VX_8@paquier.xyz>
References: <Z5xgmgyV-wnzMpkO@paquier.xyz>
 <CAA5RZ0vM9AsEqvKued2drKZJ1opt3wbYaDbxGzi-khkNzwn7og@mail.gmail.com>
 <Z6Ks3ta5089DXiPc@paquier.xyz>
 <CAA5RZ0sfRbd1xcq_oHNA0TPr57yM8qkg-GoD6A0nUfyxZhs33Q@mail.gmail.com>
 <CAP53PkxocbNr+eRag3FEJp3-7S1U80FspOg8UQjO902TWMG=6A@mail.gmail.com>
 <CAA5RZ0u6yJdFL=p5vdpbZFS-2YY+Z6vtzmt4gejgZa3RcNiWMQ@mail.gmail.com>
 <Z6lVcWdNQtgz9BGI@paquier.xyz>
 <CAA5RZ0t80hP2aTv97QtEJy39GkxKmDBVDiTBApfiuTa4O=TEWQ@mail.gmail.com>
 <Z6vmYBgLRLXkx5fi@paquier.xyz>
 <Z6v3dSJ7yEJ9xai4@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kZuqx88WszykMX1/"
Content-Disposition: inline
In-Reply-To: <Z6v3dSJ7yEJ9xai4@jrouhaud>
Archived-At: <https://www.postgresql.org/message-id/Z6wAaGieBgd0VX_8%40paquier.xyz>
Precedence: bulk


--kZuqx88WszykMX1/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 12, 2025 at 09:20:53AM +0800, Julien Rouhaud wrote:
> On Wed, Feb 12, 2025 at 09:08:00AM +0900, Michael Paquier wrote:
>> Wikipedia seems to agree with you that "fingerprint" would fit for
>> this purpose, though:
>> https://en.wikipedia.org/wiki/Fingerprint_(computing)
>>
>> Has anybody any comments about that?  That would be a large renaming,
>> but in the long term is makes sense if we want to apply that to more
>> than just parse nodes and query strings.  If you do that, it impacts
>> the file names and the properties, that are hidden in the backend for
>> most of it, except the entry API and JumbleState.  This last part
>> impacts some extensions and I have been maintaining one a bit
>> (pg_hint_plan).
>=20
> I agree that fingerprint is a good improvement.

Okay, thanks.  So this would mean something for the file names, the
node_attr names, the structures and the APIs if we put all that under
the same label.

> >
> > Also adding Julien in CC,
> > as he has some out-of-core extension code that depends on the jumbling
> > structures if I recall correctly.
>=20
> I do have an extension to support custom fingerprinting logic, but the
> introduction of the pg_node_attr based jumbling kind of broke it.
>=20
> FTR my main motivation was to be able to deal with queries referencing
> temporary relations, as if your application creates a lot of those it bas=
ically
> means that you cannot use pg_stat_statements anymore.

Do you have an issue more details about your problem?  If we can
improve the situation in core without impacting the existing cases
that we need to support in pgss, that may be worth looking at.
--
Michael

--kZuqx88WszykMX1/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmesAGgACgkQnvQgOdby
QH1vug/9EBD2q7jwJBY44tsMLC/Y4wbjb4MO4xpNcNtntLs5xHehxij3gPuKCYJx
2M5PQm7O+PgZqIb12CSWrSnq4GE7XJXu0ROFDh2eS7on7r7umjG1mf52XPrCPGad
Q45vyRt4KxCFHnWMKNKJlCNYCe7EvGI2+ajF1KDbRZstP9/MirKZ+MAfzA6AHQgh
GbWoEVEasDdUAl2YHVZMdsPVfAlB+eCnV9xRxxfa1xF7eXUOH3OGU5xZlMj1sAzZ
BVuesJzoSFlFIeNEYLUsvQp97vbzVa8i97Y5FrGqhr2TZyzzp5zjUQw1JOCgThik
23r2j1QV8D1M6YfljF+93TXMBDVG0tROCUK5U52lopuOnTSkuV6z2MXn92LOJiZ9
1eUEvi0ieBITigUTmiR0pWsGVzEttK5hQo3oe88bGcS5VtNFq/Z4MPJ1FwRxnphs
P5Zhy9k+sqieVs6BKto+KpHuh5pWfDulN09bU9gl/Hn61em1eNKFHJOh6o6MmGkt
dxQgzemaxqh22Y2j3G2dYszO/FxV1tNg1IT++qsWqBxI4FOFAQBF3f7ICq0Qmrt9
bVRHjIetyVfoLhGaenEiYp4Jv9Swt7o4Qxmz8qRvApLOA9bFNPfkQmJ2/ZT8Ts7+
jazzWI8sqOnDoK2LEFlZOJEi0RvXIkD+IeXuP0aXhmz914Wq0Ss=
=udwa
-----END PGP SIGNATURE-----

--kZuqx88WszykMX1/--