Date: Wed, 12 Feb 2025 16:25:38 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Unneeded volatile qualifier in fmgr.c
Message-ID: <Z6xbAgXKY2L-3d5Q@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="k0YZuktU0iOd7YhU"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/Z6xbAgXKY2L-3d5Q%40jrouhaud>
Precedence: bulk


--k0YZuktU0iOd7YhU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

While reading some code in fmgr.c I noticed that the save_nestlevel variable is
declared as volatile.  I'm assuming that's because a long time ago it was
modified in the PG_TRY / PG_CATCH block but it doesn't look needed anymore.

Trivial patch attached.

--k0YZuktU0iOd7YhU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="fmgr_volatile.diff"

diff --git a/src/backend/utils/fmgr/fmgr.c b/src/backend/utils/fmgr/fmgr.c
index aa89ae8fe1a..ef0fde51b38 100644
--- a/src/backend/utils/fmgr/fmgr.c
+++ b/src/backend/utils/fmgr/fmgr.c
@@ -639,7 +639,7 @@ fmgr_security_definer(PG_FUNCTION_ARGS)
 	ListCell   *lc1,
 			   *lc2,
 			   *lc3;
-	volatile int save_nestlevel;
+	int save_nestlevel;
 	PgStat_FunctionCallUsage fcusage;
 
 	if (!fcinfo->flinfo->fn_extra)

--k0YZuktU0iOd7YhU--