public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Julien Rouhaud <[email protected]>
Cc: [email protected]
Subject: Re: Unneeded volatile qualifier in fmgr.c
Date: Wed, 12 Feb 2025 08:41:34 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <Z6xbAgXKY2L-3d5Q@jrouhaud>
References: <Z6xbAgXKY2L-3d5Q@jrouhaud>

Hi,

On Wed, Feb 12, 2025 at 04:25:38PM +0800, Julien Rouhaud wrote:
> Hi,
> 
> While reading some code in fmgr.c I noticed that the save_nestlevel variable is
> declared as volatile.  I'm assuming that's because a long time ago it was
> modified in the PG_TRY / PG_CATCH block but it doesn't look needed anymore.
> 
> Trivial patch attached.

Yeah, makes sense to me.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Unneeded volatile qualifier in fmgr.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox