Date: Mon, 17 Feb 2025 06:59:40 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org,
	Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: per backend WAL statistics
Message-ID: <Z7LeXGJOMRA+dCJM@ip-10-97-1-34.eu-west-3.compute.internal>
References: <Z49KmyAIFQtDp0bV@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z5H4Su2fvuRD82dl@paquier.xyz>
 <Z5ISnjxjrxFWLISw@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z6HUpWt11kZNHey0@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z6LJ7xcXmFs_LKmV@paquier.xyz>
 <Z6M7/zq4vgE4lch2@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z6M98Y5dTQoqb3kO@paquier.xyz>
 <Z6N1eDP01ZFBcBrV@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z6QSr6rYB_fj9smy@paquier.xyz>
 <Z6SO4FKamvH83/v2@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z6SO4FKamvH83/v2@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z7LeXGJOMRA%2BdCJM%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Thu, Feb 06, 2025 at 10:28:48AM +0000, Bertrand Drouvot wrote:
> Hi,
> 
> On Thu, Feb 06, 2025 at 10:38:55AM +0900, Michael Paquier wrote:
> > On Wed, Feb 05, 2025 at 02:28:08PM +0000, Bertrand Drouvot wrote:
> > > Agree, I'll start a dedicated thread for that.
> > 
> > Thanks.
> 
> Done in [1].
> 
> [1]: https://www.postgresql.org/message-id/flat/Z6SOha5YFFgvpwQY%40ip-10-97-1-34.eu-west-3.compute.internal

Thanks for having committed the work done in [1] above.

There is still something that would simplify what is done here: it's the
"the elimination of the write & sync columns for pg_stat_wal" mentioned in [2].

I'll add it in the new patch serie for this thread (that simplifies the new 
pg_stat_wal_build_tuple() among other things) unless Nazir beat me to it.

[2]: https://www.postgresql.org/message-id/Z6L3ZNGCljZZouvN%40paquier.xyz

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com