Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 27 Feb 2025 12:09:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [BUG]: the walsender does not update its IO statistics until it
 exits
Message-ID: <Z7_Xemj8ll0RgcIc@paquier.xyz>
References: <Z73IsKBceoVd4t55@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z762lusJXp_wNF_z@paquier.xyz>
 <erpzwxoptqhuptdrtehqydzjapvroumkhh7lc6poclbhe7jk7l@l3yfsq5q4pw7>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WKE5UFSrm2vbNLTB"
Content-Disposition: inline
In-Reply-To: <erpzwxoptqhuptdrtehqydzjapvroumkhh7lc6poclbhe7jk7l@l3yfsq5q4pw7>
Archived-At: <https://www.postgresql.org/message-id/Z7_Xemj8ll0RgcIc%40paquier.xyz>
Precedence: bulk


--WKE5UFSrm2vbNLTB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 26, 2025 at 05:08:17AM -0500, Andres Freund wrote:
> I think it's also bad that we don't have a solution for 1), even just for
> normal connections. If a backend causes a lot of IO we might want to know
> about that long before the longrunning transaction commits.
>=20
> I suspect the right design here would be to have a generalized form of the
> timeout mechanism we have for 2).
>=20
> For that we'd need to make sure that pgstat_report_stat() can be safely c=
alled
> inside a transaction.  The second part would be to redesign the
> IdleStatsUpdateTimeoutPending mechanism so it is triggered independent of
> idleness, without introducing unacceptable overhead - I think that's doab=
le.

Agreed that something in the lines of non-transaction update of the
entries could be adapted in some cases, so +1 for the idea.  I suspect
that there would be cases where a single stats kind should be able to
handle both transactional and non-transactional flush cases.
Splitting that across two stats kinds would lead to a lot of
duplication.
--
Michael

--WKE5UFSrm2vbNLTB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAme/13oACgkQnvQgOdby
QH0oPQ/8CL1rtwNTtMpjfFT8xzqroJE8uldpOpWF37tDZevF3NvY99QCjsXbwgLe
Vwy9zdvcdRjgNmjKn1bWzJcDoHIO6ipRmxTRGnfh1sCEzzd8fFoN8QobJE2STTd4
GD73uw2NEvsIg6aLuMs+D1b8NPtfLMXULE/8BxWN3leJbO9755uOoQcoZxLl6Pzb
1Sw+A6s55JrkU4/uScV9UGqC/YBRt+MJuI0dmPuKaKayGIFTa8OKKedvN04mhscD
y5d5kXSJFkzkiZkJBxnm65zfVnR812INpW+hJ3uo6sfd+A5yNNnIu5WKMKa9ha9G
56AlBOTEYr8rXJT72LJLsXaNsgW7PkjZkCPPOxzmfoTSqyiayFhS0IU+k24nkkvq
OOUQfhQMiKlK5tcn69sGEobCrOwsa+USnTXVffbS9WpSfBX+IzUD2Pl0AAgsNNPT
iGvIuz8r+WUwiKRLxbb8BKY3y3A7t3N0gMajbwRRQ3ZwEnyfnDMlJeUP3l3PzP/N
jLPks+6G8bcgVOZUQib2uUFcdo4lTLeoQVw6+Ooc7Yr8mPg5WCGBJct2w7j3XZSM
zk07K62F8fjbjfsLogjdp+YNUZYd//nSmvG8lilULI/ncsguSn4LkWOFjfx9oqiZ
eAZcpNLJOZLIoqMv5IoJt/Uvi+AuWTDEq3viAEdaT46zK7KWGTw=
=oWGV
-----END PGP SIGNATURE-----

--WKE5UFSrm2vbNLTB--