Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 28 Feb 2025 17:44:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [BUG]: the walsender does not update its IO statistics until it
 exits
Message-ID: <Z8F3ZH0kLeYz4yg7@paquier.xyz>
References: <Z73IsKBceoVd4t55@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z762lusJXp_wNF_z@paquier.xyz>
 <Z77jgvhwOu9S0a5r@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8FMjlyNpNicucGa@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Q4iIfB82r/ZAHzhu"
Content-Disposition: inline
In-Reply-To: <Z8FMjlyNpNicucGa@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z8F3ZH0kLeYz4yg7%40paquier.xyz>
Precedence: bulk


--Q4iIfB82r/ZAHzhu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2025 at 02:41:34PM +0900, Michael Paquier wrote:
> With smaller records, the loop can become hotter, can't it?  Also,
> there can be a high number of WAL senders on a single node, and I've
> heard of some customers with complex logical decoding deployments with
> dozens of logical WAL senders.  Isn't there a risk of having this code
> path become a point of contention?  It seems to me that we should
> benchmark this change more carefully, perhaps even reduce the
> frequency of the report calls.

One idea here would be to have on a single host one server with a set
of N pg_receivewal processes dumping their WAL segments into a tmpfs,
while a single session generates a bunch of records with a minimal
size using pg_logical_emit_message().  Monitoring the maximum
replication lag with pg_stat_replication and looking at some perf
profiles of the cluster should show how these stats reports affect the
replication setup efficiency.=20
--
Michael

--Q4iIfB82r/ZAHzhu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfBd2QACgkQnvQgOdby
QH2R9Q/9E72vaaFsCUrJ9LC+VMGmSye/ACNPUz4xyt7LihfMLHNcShLxDHofY4fM
l2YVgJsrNXH9aX187MDUh31BKiNrYwmC4WKgzuc2x4hcqJBT17mNqQDyu3nWRDfK
iyoWGRolkrcTMmOoGAgw4PkcFi+Y49GFVO9LHI9XCUPPuEd5IA2+BDmDPVvhvcAh
PQ9EYr4xcOz+4nGy40b5q28rV+xQ+UzaSEqaW1lBVTr7NKiJm50ZFxBRkbnQXJdp
8mDs/8c6IfgWFAROQkORs43z/z0hs4lkCsTTYE+MTvGmR2tjhaU7+UP2ZVpX0qtP
vJ6nNbzZGY1LFI2hgurLYxCU5WytzCJGF/RpeKTiXrGeTshq+6dLPcFjU2+7lqLG
wUySmM0pmlbel9x0OyQJUb5iVY/xp6lLwi/z7Xh5DmIzYfEP2c+4Z50nSy6WxNba
zQu3vyy7sN/GaxkvLR30XRuaULyO9Zes3mnF/e8R0q2Ns9N3sNVO/N38MYbgpTYx
uzE3N6+hne7ePC7isFc3V7h+cWXwwFTxa4mDzK35YJ/qD4a80H5UCH7ezbB2Bl1P
qHuabxaenTDrqMHozspE8TQxM2KPQzbOtMf5MdDttJ15zH8oiopL/U2R6TfiuPkJ
abYhh4ySCZxjZEYn0/QiYKjpdojBCmv+OW4ypJNGW/8zDnMizA8=
=2vNi
-----END PGP SIGNATURE-----

--Q4iIfB82r/ZAHzhu--