Date: Mon, 3 Mar 2025 14:07:12 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Guillaume Lelarge <guillaume@lelarge.info>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>,
	andrey.chudnovskiy@microsoft.com,
	Jelte Fennema-Nio <postgres@jeltef.nl>,
	Jacob Champion <jacob.champion@enterprisedb.com>
Subject: Re: Log connection establishment timings
Message-ID: <Z8W3kClxw3dxHdAa@ip-10-97-1-34.eu-west-3.compute.internal>
References: <Z45lUorFBcmCKxp7@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAAKRu_YrNsA7-v5L9d318XZu+tPqcxp+ctCGy2EGYrSt69ON=A@mail.gmail.com>
 <CAAKRu_aV+B2yLpkcfh06tJV7XQPodjasxQ=XKh+MjD8ixkXwrA@mail.gmail.com>
 <65fe2d68-a214-40f0-80a8-56ca7323ad5c@oss.nttdata.com>
 <Z77Fxf49c+LIW74a@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAAKRu_bWRipJ2HA8cwvxrZOhSpvpPLkvhcBHecXBx8_wS4cjQQ@mail.gmail.com>
 <Z8ALQSr1o0AoGpAo@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAAKRu_Zv7e1GWHiTJ9UOZEoqs8hO8sCezZZNuPv7s5mGYe_QkA@mail.gmail.com>
 <Z8FGpTkLIF7M3+M/@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAAKRu_Y0vHiDZgsnPriUeFe22NJz6zx-ukbODYJPHreAE1iONQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAKRu_Y0vHiDZgsnPriUeFe22NJz6zx-ukbODYJPHreAE1iONQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z8W3kClxw3dxHdAa%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Fri, Feb 28, 2025 at 05:42:37PM -0500, Melanie Plageman wrote:
> And all of these places we have to be super
> careful that the GUCs have already been read before using
> log_connections, so it seems a bit unsafe to check log_connections
> (the global variable) in a function.

Yeah, that could be checking before calling the function (the caller would be
responsible for checking log_connections)

> Also, I also wasn't sure if it would be weird to call a function like
> "LogConnectionTiming()" which in many cases doesn't log the connection
> timing (because it is a different backend type).
> 
> But maybe I'm not thinking about it correctly. What were you imagining?

I did not imagine that much ;-) I was just seeing this code being duplicated
and just thought about to avoid the duplication. But now that I read your comments
above then I think we could just macro-ize the child_type check (as you mentioned
up-thread). That would avoid the risk to forget to update the 3 locations doing the
exact same check should we add a new child type in the game.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com