Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Mar 2025 08:11:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Pipelining support in psql
Message-ID: <Z8eIqOWhTT5Sao82@paquier.xyz>
References: <CAO6_XqrrjJRhKNhYa9Cg=_BSH8MmS1tAHMFq-H7fH=NcWJ-jvw@mail.gmail.com>
 <ad4b9f1a-f7fe-4ab8-8546-90754726d0be@manitou-mail.org>
 <Z8ZP17bZfwxFV_xJ@paquier.xyz>
 <CAO6_XqqFVQjLjZQiL7xdwLpzZEy1ghO_JWvCFPM_OmwF9s7XdA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+HzmqUPArNb1MgVA"
Content-Disposition: inline
In-Reply-To: <CAO6_XqqFVQjLjZQiL7xdwLpzZEy1ghO_JWvCFPM_OmwF9s7XdA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z8eIqOWhTT5Sao82%40paquier.xyz>
Precedence: bulk


--+HzmqUPArNb1MgVA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 04, 2025 at 10:31:46AM +0100, Anthonin Bonnefoy wrote:
> Saving the printQueryOpt when a command is pushed was an option I had
> in mind if that was straightforward to implement. However, even with
> savePsetInfo, you will need to save values like gfname and gset_prefix
> since it impacts the output (it may make sense to move those in
> printQueryOpt). This would also need to be saved for all commands,
> like \close or \parse since we don't distinguish if a piped command
> generates an output or not. So that definitely looks like it would add
> a lot of complexity for limited benefit.

Yeah, same opinion here.  I don't want this level of complexity with
extra manipulations of printQueryOpt when fetching the results,
either.  I'm all for making these meta-commands to what we think is
more natural, but not at the cost of a more complex logic in the
result printing depending on what's been given by a meta-command when
a query is pushed to a pipeline.

> I took a stab at creating the \sendpipeline meta-command. I've also
> realised there's a small leak where fname is currently not freed on
> queries like 'select ... \bind \gx filename' when within a pipeline,
> which is fixed in patch 0001.

Indeed.  Fixed this one for now.
--
Michael

--+HzmqUPArNb1MgVA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfHiKgACgkQnvQgOdby
QH1+7Q//S9p5DotWO6NGfdaaIq3skai+dLMy/m+wF85Xrt1yC0+r/GDmx9AYDwYD
fZks3dCp7IpMYBTptW0bv3VWLzVSv6JW7lJ96pmHajL5LmRobhH5sQ5JFgYfnNji
nYk99mACD41Tuzzr3kRarve7eoCf8mh+YkKhSVFXZj2pCXD0C1Z6IrGc555ZFMhC
I3NUgRkO999o9rZTU+fyV3dyjZtukRk5sS0svJDebPdstyJFr3MNxkmn2B1S8R7U
JO3ai1RH0Gt6Z4PfWaUuLs9VpVKJRPH6D3Z501zSmL4JFB6s8tAKhGAiDObevffI
av5phr+SRzQrFi2D/nrvpambJE5qVeb7YB4/c9B+4I4Vje88fMviR2c6u+qjY+Ze
xLTOfSuRzIYm8NIn8DHKYbQofxbkW5ECvxBhb/jS/pYOtwar1IKwaqsjf7rg39St
6MH0kPBEBuEHh20PzrAhst3jm5a9/LfQZSEZXJwuBwwKpl87MLB0NwqdhdaCcRE6
5uGBO0Nqv9GNI0wWNZRK2qXaR/jKRfujXK182b0VedmeiKo4kozLAwf/GZ1RVggA
EhTNivrdtMn+CuuMJtOxsODgiKTk5gwqgjCJ4nGspv6KAYuyfCbLAGehY6sAVfwL
/UXngWOHSiMbpSOjJewUlg2xBpTY3LpqfX5xfsxNVAUsFSMvQTg=
=aLos
-----END PGP SIGNATURE-----

--+HzmqUPArNb1MgVA--