Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Mar 2025 08:25:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Pipelining support in psql
Message-ID: <Z8eL7rdhDLndyvuS@paquier.xyz>
References: <CAO6_XqqFVQjLjZQiL7xdwLpzZEy1ghO_JWvCFPM_OmwF9s7XdA@mail.gmail.com>
 <d67b9c19-d009-4a50-8020-1a0ea92366a1@manitou-mail.org>
 <CAO6_Xqroaof=Gu_NCg4bZfpdgwOjNW9fg753cuuts-FBnv9UGw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="25Q/UCNiW+8GvfWN"
Content-Disposition: inline
In-Reply-To: <CAO6_Xqroaof=Gu_NCg4bZfpdgwOjNW9fg753cuuts-FBnv9UGw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z8eL7rdhDLndyvuS%40paquier.xyz>
Precedence: bulk


--25Q/UCNiW+8GvfWN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 04, 2025 at 06:37:09PM +0100, Anthonin Bonnefoy wrote:
> I do see the idea to make it easier to convert existing scripts into
> using pipelining. The main focus of the initial implementation was
> more on protocol regression tests with psql, so that's not necessarily
> something I had in mind. I have some reservation as it will push all
> parameters in the query string which may not be the desired behaviour.
> But on the other hand, if it is to convert existing psql scripts, then
> everything was already pushed as simple queries. Plus, this is similar
> to what pgbench is doing when using -Mextended or -Mprepared.

Hmm.  Simplicity is tempting here because we know the status of the
pipeline when sending the query.  If we do something like what you are
suggesting here, do we actually need the \sendpipeline at all?  We
should still prevent \g, \gx and others from running in a pipeline
because of the format argument raised by Daniel so as we restrict the
use of meta-commands that can manipulate the output format, right?
--
Michael

--25Q/UCNiW+8GvfWN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfHi+4ACgkQnvQgOdby
QH0S1g/+OgrjdsXu2a2sJ/wmDpq+pg6vSU0BBnX0169bRX2ab4qG6eAHm6NC4V88
SXl8MTJ5FR/OdaxN2hjqu90F6NiUOzpnYfzaBXHtTWqObtr5bRZ115sTOx1pLbjA
tAYFp5BBj0dzhRQ5MlW8y8ZOjlvweaoonpiUWOhnC0iPBWxxciqhf9aIHZhZ8Lpf
L/DQxqxMzWCfD4ckfSCcQBhNwy59n6R6vDWsCZ7SUaFoY/s8/VpJNvw2TsBclQIm
9EM5DPTGquH03v30d4wFED41O4nP/UdtqgCXk5kEZ03ufmlQq09XEo7AuqCBKyjp
iYSLtHIRdiSEkZVQ4k6Y7CZDO0AiBU4pdcpJRupJY0ZnXzbA6PgqaCwLADG3c9Pn
vsAPY+y03ZI0tf+2/VrUHaXmjrKQaY79mGKxIV60bzBJkUCY/MRtncoMEMh3B9xk
/kkA9VyQSwSa5V+14wTVeUoPqmIJ1vK13/HYUi4E49atQBEiL+I5W84pYvinSz/5
3zJl25dxNUDKPLXjGD6d2bdAHFhB0I7qfcTuiRPAAHPMqw7ATL3VxjhJ5Hivghrp
vbA8tHuWQkUd9Y3pcNXsthz1t+QhB25ScFdRBKRkxHQSWP0rQWqIZK4DSimJVzXW
HF+OxqvL935YueANlTkA0UAMF8QISWlClTggxTJKrP4n44v24fA=
=kuNk
-----END PGP SIGNATURE-----

--25Q/UCNiW+8GvfWN--