Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Mar 2025 21:28:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Monitoring gaps in XLogWalRcvWrite() for the WAL receiver
Message-ID: <Z8hDZ6jJ69q0WxTd@paquier.xyz>
References: <Z8fGfhpnUoeNSy4M@paquier.xyz>
 <Z8gFnH4o3jBm5BRz@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2XO9DORml+ecJRoi"
Content-Disposition: inline
In-Reply-To: <Z8gFnH4o3jBm5BRz@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z8hDZ6jJ69q0WxTd%40paquier.xyz>
Precedence: bulk


--2XO9DORml+ecJRoi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 05, 2025 at 08:04:44AM +0000, Bertrand Drouvot wrote:
> On Wed, Mar 05, 2025 at 12:35:26PM +0900, Michael Paquier wrote:
> Also for sync? sync looks fine as issue_xlog_fsync() is being called in=
=20
> XLogWalRcvFlush(), no?

Yes, we're OK for the sync data aggregated in the WAL receiver on
HEAD, as mentioned below, not in the back-branches.

> We're not emitting some statistics, so I think that it's hard for users to
> complain about something they don't/can't see.

One would see idle data in pg_stat_wal on a standby, so the lack of
data could be annoying, but I'm perhaps the only one who noticed
that..

> Same logic as in XLogWrite() and I don't think there is a need for a=20
> dedicated wait event, so LGTM.

Thanks.
--
Michael

--2XO9DORml+ecJRoi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfIQ2cACgkQnvQgOdby
QH02NA//Zf2M3DbCvwW3OP5W+5R27hYStyntkqGz0a2dXJfA9IycveHCEY4LazSN
aAegGtrdDCdjjnmHtrYqx2DYbBwKb/vqVakti+82ucn9e+/xno0ILykltziOvYcX
lwdwDH9gJmmLrnbLO0S0UgJrMZlZCdmR5UA04BKfH0etiVDAUOjbEje6NiRZX8We
OFxesXx0IrF5naMZhKJtHDOP7UCldiKvqxnLadUXNNfKbA93ArIir24fYf8x0nUQ
bmNfNtV/6XTL87XiW0ukMVZ4hOcDFiaaQ4qLs/EVff0XsJIvyJ7TIysS6ijFeNkY
cSplnPoiPL1tV3r5SGHc1qdZNFVlN6UGJGw81zYid2C09marQnZV80fLOeBzwQk3
6ns+pU+MheI/SOojIr0s7ZWLaXaXUS2D//NmWlikEDmKM92wLVnH0rQD2W4aWLQo
rEGMF1/lISBAKwfXT0JS7a0DBdM3lDDCS87or+/EEqxkPI3L+9jcDr8/+k2ZSFKk
puyyLlkrJVWUvZVq5aKifBxr4IBbe7uk70gNKn8gZb95rIRrj6sF9DNGomGS5QpU
hroPLUR8aB1dsOyFdv8Z5WFD6UH3vfXpTavqQg86/P0M0d0Rf8FivBOR6TrlEUly
GQKFfGpZ5COKBvhtPABzqCQnbOTMBmFNId5OnLZCOvdn6orF2Qo=
=3Cio
-----END PGP SIGNATURE-----

--2XO9DORml+ecJRoi--