Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 6 Mar 2025 10:12:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Monitoring gaps in XLogWalRcvWrite() for the WAL receiver
Message-ID: <Z8j2hf0rgwboEg-1@paquier.xyz>
References: <Z8fGfhpnUoeNSy4M@paquier.xyz>
 <Z8gFnH4o3jBm5BRz@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="41veOy51BVAaKRZk"
Content-Disposition: inline
In-Reply-To: <Z8gFnH4o3jBm5BRz@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Z8j2hf0rgwboEg-1%40paquier.xyz>
Precedence: bulk


--41veOy51BVAaKRZk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 05, 2025 at 08:04:44AM +0000, Bertrand Drouvot wrote:
> On Wed, Mar 05, 2025 at 12:35:26PM +0900, Michael Paquier wrote:
>> Perhaps there's a point in backpatching a portion of what's in the
>> attached patch (the wait event?), but I am not planning to bother much
>> with the stable branches based on the lack of complaints.
>=20
> We're not emitting some statistics, so I think that it's hard for users to
> complain about something they don't/can't see.

Hmm, not exactly actually.  I've missed that ff99918c625a mentions
that WAL receiver was discarded on purpose, but this was still when
pgstats was not in shared memory and still file-based.  We scale much
better now.  It is not that difficult to make XLogWrite() hot enough
that it would trigger a lot of calls of pgstat_count_io_op_time() per
ms, either, like the WAL receiver, so as long as the timings are
behind track_wal_io_timing we're fine.

Let's do this at the end, without a backpatch.  At least we'll be anle
to get better IO metrics for replication setups.
--
Michael

--41veOy51BVAaKRZk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfI9oUACgkQnvQgOdby
QH07ew/+ItaxRaohhxbQTkIfzbP5iwv2JoOgLLTOHqMsRTajjc9Pa9Chbd4e1vio
yUAtWtbcg8vw4ryV0DPSghAVHJxfnZHB9iRctlPFLdNOkzZrcIEIUz/D+FOS2v4L
1Lw2lHpfXYaK4dhkHcxuK5Dj0XpPnsT60BfoKZVOj4hsGtq1EkOzBz+jkNgFrRBJ
c3lNCOYGUZVsbP7bj1mO0MZr1yrIaKhQTMklDMbWnthsVzJrwEfurtRiY3HL5FIx
1JCoA2ozLxtB9zE6Yb1BC86ytxNkdCacSGMrm66dzSzX2xNwu9uFqkp7NstVsWJA
wzcr0YIkdnSRW2rRk+/V5FrdHl7ZSJARt4nAGwnA1VA79MVLMRi/mKIlL199853I
O/wbW3Xewyn9xWTQDgiHSLFJ8QzkPuCyQDpCv7xfqEMOlnaUA9z+VG4sqUsVcV6J
Lo1N1I9jVZmV9LXTiHu5eH0s/eEKHBO8qH0E8zzUjeJqwKmLudJ+8avE6uOirwDw
VB2Zq1jJdmKF7IbEnNBReRSnGXk+dIJOXDatE2ZWqguboJ8sQDeDyNCyFrxwW5lw
tyVv/igEjyMQW0yN0QduV/VRpDTWphE9euRGEBNNSOf/a9g3P6Ix9SsIwrV/AFoM
qlmUQED7xBUfWXUjayNGMlsuAdQFiXpA8BR3kCOanTPxF3p8RZY=
=GVy0
-----END PGP SIGNATURE-----

--41veOy51BVAaKRZk--