Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqp4k-00Aoym-9h for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Mar 2025 07:58:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tqp4i-00BtDe-Bc for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Mar 2025 07:58:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqp4i-00BtDV-1c for pgsql-hackers@lists.postgresql.org; Sat, 08 Mar 2025 07:58:24 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tqp4e-001eMl-1J for pgsql-hackers@lists.postgresql.org; Sat, 08 Mar 2025 07:58:23 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-390effd3e85so2306197f8f.0 for ; Fri, 07 Mar 2025 23:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741420701; x=1742025501; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MchVVQwDl+UiulpNIfYu8CGjFGWoXz7J5sXmDkPg5gY=; b=gNcJiLVQwA25s4gNIyNMoPpteuwFrkOaDrlorZtb09bmGKjjaaDE7tLEsoWTVDrLK8 nDmnXffxn+oiVA40dHBHpUal6qVuIMO7cGdmttQD6tffviiseT9UWS7MBam0M/nKQ+8u c5QWYskAhbLQFiMtzmltmYetD3l7/KNEHR+mvUCBeubXdGJGXoUvqjcz6AnB0vduaniQ VOFBfZsM/8lO4JRb9m9W9uEYlpXT0n5CqTWMI/CvNNXw34tdU5HruPAJj5rYUfA9mbtX qRkWX9eV/ybaU5/mxSrTCGpnsRTttjQWv0hHWoYqGh6HBAOpJa6eRU5r6hGC8KkNoMkZ 6f2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741420701; x=1742025501; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MchVVQwDl+UiulpNIfYu8CGjFGWoXz7J5sXmDkPg5gY=; b=jp8wprPQIw0mRmy3R63Jo+FVJynjjH3eytEgp1/UMmPopcP9U8LS7HZ11XuDtzn28o swO/u8DfLGFhjGlGffd6E+HjA2Hcx+zR+Uj3IMvQ3KOdf7MX0CKJ95jVl1J80khYae/2 Qnxvy6N3VIEymMW2qWbW48OqPkyp7ggOOnMhGF5MDoCAGEkp8YBna0RsWkBNm84ZaMj1 l3YyrbNPSR/gVStZ+Eipe+mHFbwqxPk87f0jtyHaTPBlHCh54Gm4kiHrDHLZVEDMLvnb oKJEL1EsdA5TT4gdsWPqMxteMtTT4HG7RU80lnlkRn9qCb1NgdEAs1M6lRfxi5u1n2xy 2n0Q== X-Forwarded-Encrypted: i=1; AJvYcCVlIk/yW5k7D/MfIDfb500RwPgCrhNufEaZDSyM6MT34UC66YqA2CfFUnFlLOXfPkzII1E5zCZK11AaXAI+@lists.postgresql.org X-Gm-Message-State: AOJu0YwMFln4lPo/z85YFsDG1q+MUXyqofBwlqS9EVIQhWEJyJsL9vdx tR8havv++P0X5hb8gWbTbhDHGar44v9CSi2wjsBLzzeSVDR+pVcMeZCdyg== X-Gm-Gg: ASbGncvfVsNNvzeayOvGeADa4RlAayJI4ms2DnRcEshvs9ObacuPatcSsvLdbBfVElK TmX2P+M6KXwJk486uGYp5wiDWlP+d+kd9KCp0eEVYJ5ql/4ho8YznufK8iIkvwzGOn/HVtibhTl Vg5HdYgSYzQ6Sj30mKwzShGUI5NtBh8qIzTvKhO0ThgbDP/0t7KNNCtzWzhrtuyyo1gWYF/8PDw HRGPPC2PhmXgQ3yctaB1/4qgGh+im+9XoT6v/BkFUP4ogFsG4krRtP4zUEsGnkQ1PPxpUnHo6En 3YzdZ1W5WQG8b2m9s32aLm+aey03Ere0hIfF7hR5l+LyjZnLMbd00D9AQ1YO76pRKwXZv4VdT1+ osyZhs5Hc/E56qh2z5MhZb3N1Rra/wY0KwvUGPhufDTIT34B8a+WT36HrraKbLbl78OmtMyyDL/ sr X-Google-Smtp-Source: AGHT+IFeyr4XIyIuC0LifMwYDmlUnGDW4DiH72ZiLdF0L/rxbloC0y4jlaE+QbzGGZuolwhjNesFEw== X-Received: by 2002:a05:6000:1ac9:b0:391:901:311c with SMTP id ffacd0b85a97d-39132d828b5mr3935376f8f.32.1741420700620; Fri, 07 Mar 2025 23:58:20 -0800 (PST) Received: from ip-10-97-1-34.eu-west-3.compute.internal (ec2-15-237-181-182.eu-west-3.compute.amazonaws.com. [15.237.181.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cebd6d359sm5765265e9.10.2025.03.07.23.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 23:58:20 -0800 (PST) Date: Sat, 8 Mar 2025 07:58:19 +0000 From: Bertrand Drouvot To: Masahiko Sawada Cc: Amit Kapila , Andres Freund , Peter Smith , Peter Eisentraut , shveta malik , Bharath Rupireddy , pgsql-hackers@lists.postgresql.org Subject: Re: Add contrib/pg_logicalsnapinspect Message-ID: References: <5qbxud4pvnvmtuoi7weiizm5hmumxaeohx4vztfhrwlfhyz6rj@buh4435mllwo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Fri, Mar 07, 2025 at 12:09:35PM -0800, Masahiko Sawada wrote: > Thank you for updating the patch. It looks mostly good to me. I've > made some cosmetic changes and attached the updated version. LGTM, thanks! Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com