Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsQvi-001uF0-Ij for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 18:35:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsQvh-00Auyw-BM for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 18:35:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsQvh-00Auyn-1K for pgsql-hackers@lists.postgresql.org; Wed, 12 Mar 2025 18:35:45 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tsQvd-002Uty-2C for pgsql-hackers@postgresql.org; Wed, 12 Mar 2025 18:35:44 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-72736498817so78338a34.1 for ; Wed, 12 Mar 2025 11:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741804541; x=1742409341; darn=postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Vp01RLSDAp0FRmiw01Al7BFRKbBH9yAyEo0LD14zQb4=; b=ZS04sVKThktzceYRU0gVHa69eU7woDc1gNtYQa0mv66EL/WSkg6/UGfaw/ajeRN0RT Dcn7sCWMqrDUGahhYVs8KlKtbu3pVzOpc6agTRG1s/A9S1/vTxooBuHsWiPn4KO/Zsfs oxvYD9bcmrxpG61r7z8Tvyz5QFLzqDqLPCoH92iPPMoCodLUVaC+V1JmJ8mfV00GQJbn MACh6rD/deZtL8/8YKhLnGo7KVredVv0Q+E7oM75cemR4GABVxZtEoQm9suefwKmI19X l7Qz51RyRHnSMahZdGn3rIFSIUiW4UpoHRFZoMBltDPxKsjSKRru0Xh84ALyXkED6Nic e+KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741804541; x=1742409341; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vp01RLSDAp0FRmiw01Al7BFRKbBH9yAyEo0LD14zQb4=; b=VdubhxJRsKVzmovNwuZPbmvWRfMzkL9VL8MlpOX/OymQ6e08Js7oZWILK4z3Xf6NKP UjxheUj+oaL466XwNeVD/qC5IQm4PLZwGftZktoB5U1ESOuQsXAglfqT1lIAPR0lQHIu jIvxoiMy188XdLLe9oo7AptpUZTTbDU/PInXOpDgyQDP05Bbw146pWB0fTnuxTSWwtjl aSZG7Sv48PCZRnchnDvXC/n4dTQL5IjVbgIAsOeEQaDBNbDtWeyY2T8xyWXziszxbgez ayATQEyY2HqciC8h+/0ryDQ1RSxNyUvMr0lU9HmfDmDhy0ee7zpK9amP0gBrhgQXcxYl Exgw== X-Gm-Message-State: AOJu0YwE8PUOVWghX0yRQsMShicYMwnBOW44YeYr6t5x/DmNdvzQX1yK aX/CJ5U2E40e4unt9zkiVHC4LbomYyZ1zc2Ogw3BLbl3DA+WPdatSK6FOw== X-Gm-Gg: ASbGncukgPDUz0b4/Lnawi2Kau9zEJZrdYrr+BnazfqpseN6qmWBdgovppejHlYH0fK I/70Tznpu1aDDdJ8NS1hFnQEP5JL1SZi4BprieKI2eyifeILn7ha//y8PmC1Kru7HO9Ird0dLQV eh//B8nX7EoqKnZBh1XX/KrL0u48J2/jTmjXAdUZVoNFBAD8LfJP/rNiPVSnt1B5Wt340b/3sFR fKNf7w6UfoJGVQO+Z0zpz3pMh7sUPuF3A/uJX7EIwRNZEKURl75ZJZGScKCZzFKg4M8Eu6nMnnV Nvl3MGx9lxs4bFQl87ZkpLUDEjJJBF/XxZ0mGy34bWtbWteebdNL3yzV6gtghR65/fHxd421wJ5 ACwfsDBmO34UKxoGkZDzBDuMHlkIV2pEHQbw= X-Google-Smtp-Source: AGHT+IHWlhTtPVHPC+GeWtINtdTD/M3Tm2oXIPDSYk3iYDNXB2QFO9zBNnWmOLKCwBGEffu7s3Cdxw== X-Received: by 2002:a05:6830:3495:b0:72b:8326:f0c7 with SMTP id 46e09a7af769-72b8326f7aemr7338617a34.28.1741804541309; Wed, 12 Mar 2025 11:35:41 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72baa9caa74sm238588a34.4.2025.03.12.11.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 11:35:41 -0700 (PDT) Date: Wed, 12 Mar 2025 13:35:39 -0500 From: Nathan Bossart To: =?iso-8859-1?Q?=C1lvaro?= Herrera Cc: pgsql-hackers@postgresql.org Subject: Re: remove open-coded popcount in acl.c Message-ID: References: <202503121834.nrw4lp5mwd7v@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202503121834.nrw4lp5mwd7v@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 12, 2025 at 07:34:16PM +0100, Álvaro Herrera wrote: > Thanks :-) I confirm that this covers the code in select_best_grantor > that you're modifying. Thanks for the quick review. I'll plan on committing this shortly if CI is happy. -- nathan