Date: Fri, 14 Mar 2025 14:05:30 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, Jeff Davis <pgsql@j-davis.com>,
	Corey Huinker <corey.huinker@gmail.com>,
	jian he <jian.universality@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	alvherre@alvh.no-ip.org
Subject: Re: vacuumdb changes for stats import/export
Message-ID: <Z9R9-mFbxukqKmg4@nathan>
References: <Z8XXEYfbSatGrrty@nathan>
 <CANWCAZYrk4ky6+AFp7Yv8yRyMrYHiMs6EnF8rmz3uey1rtkONA@mail.gmail.com>
 <Z8c0s_eC7X2yWwC5@nathan>
 <CANWCAZacHEinN0tYUwHahzeJguDoannP0Nksv9LnLPpFD2kb+g@mail.gmail.com>
 <Z8oX2u2Db8x2Y1za@nathan>
 <CANWCAZa3tOfy2t7PraGh7td0nuO8rLesE8Cp2D1QZ+vM0hRcxg@mail.gmail.com>
 <Z88AgUXOR3e3ZsDV@nathan>
 <Z9BsEfqEmwkUetgz@nathan>
 <CANWCAZbiLHGeAZPYg6G6eT6MmCXM7CuYBEj3WhWw76e_HQejDA@mail.gmail.com>
 <Z9HhrtaZyFgMvJsM@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z9HhrtaZyFgMvJsM@nathan>
Archived-At: <https://www.postgresql.org/message-id/Z9R9-mFbxukqKmg4%40nathan>
Precedence: bulk

Out of curiosity, I generated many relations with the following command
(stolen from [0]):

do $$
begin
for i in 1..100000 loop
  execute format('create table t%s (f1 int unique, f2 int unique);', i);
  execute format('insert into t%s select x, x from generate_series(1,1000) x',
                 i);
  if i % 100 = 0 then commit; end if;
end loop;
end
$$;

And then I ran a database-wide ANALYZE.  Without --missing-only, vacuumdb's
catalog query took 65 ms.  With --missing-only, it took 735 ms.  While
that's a big jump, this query will only run once for a given vacuumdb, and
--missing-only is likely to save a lot of time elsewhere.

If no feedback or objections materialize, I'm planning to commit these
early next week.

[0] https://postgr.es/m/3612876.1689443232%40sss.pgh.pa.us

-- 
nathan