Date: Sat, 15 Mar 2025 18:00:36 +0100
From: Christoph Berg <myon@debian.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Quan Zongliang <quanzongliang@yeah.net>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Available disk space per tablespace
Message-ID: <Z9WyNDhDcXDUy4xD@msg.df7cb.de>
References: <Z9MfiPfZULuzsedO@msg.df7cb.de>
 <2df8509c-e28a-467a-8f03-f3cfe812ed62@yeah.net>
 <Z9RNywZyd364KcZL@msg.df7cb.de>
 <CA+hUKGJyzmcguUV44M2Mi798scf7DfNoCGsia0zfRBU6ZSdcvA@mail.gmail.com>
 <Z9Vt6QYesJry7209@msg.df7cb.de>
 <CA+hUKGJdSAj+5r3a3yBiYVrBC9QxtqoghrWfng6BPLVgSWLwfw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGJdSAj+5r3a3yBiYVrBC9QxtqoghrWfng6BPLVgSWLwfw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9WyNDhDcXDUy4xD%40msg.df7cb.de>
Precedence: bulk

Re: Thomas Munro
> > Hmm. Is looping on EINTR worth the trouble?
> 
> I was just wondering if it might be one of those oddballs that ignores
> SA_RESTART, but I guess that doesn't seem too likely (I mean, first
> you'd probably have to have a reason to sleep or some other special
> reason, and who knows what some unusual file systems might do).  It
> certainly doesn't on the systems I tried.  So I guess not until we
> have other evidence.

Gnulib's get_fs_usage() (which is what GNU coreutil's df uses)
does not handle EINTR either.

There is some code that does int width expansion, but I believe we
don't need that since the `fst.f_bavail * fst.f_frsize` multiplication
takes care of converting that to int64 (if it wasn't already 64bits
before).

Christoph