Date: Mon, 17 Mar 2025 15:30:31 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@postgresql.org,
	bruce@momjian.us
Subject: Re: optimize file transfer in pg_upgrade
Message-ID: <Z9iGZ14YlMGZwBnw@nathan>
References: 
 <CA+Tgmobi1aiWhtfJXL2PZsEsXOHRivRykMxE1kcTDb4EwEfj-w@mail.gmail.com>
 <CA+TgmoY6VZT=HzuJ_zfrt=2Vi7EHfVfwMd3AOuEfw-f7aeR-AQ@mail.gmail.com>
 <Z8IWHJ7OdMnQ45ur@nathan>
 <CA+TgmobD+yMc_jkmk=Vr0UWm9y8AyRFdH+CLZaCukFUoXpCG2A@mail.gmail.com>
 <Z8Ihz3by-r5t1m30@nathan>
 <Z8ipQBLNySj8e7WD@nathan>
 <CAKAnmmJhiSkOvQR1eNkW3-jmdz96gbMvO6tjva-9qAO0OzvQ5A@mail.gmail.com>
 <Z8kJveW4yBOI7Jtx@nathan>
 <Z9h5Spp76EBygyEL@nathan>
 <CA+TgmoZmffymTYV52+a6QFYMAnLe-v4U_P-yqwxqJZ38Hc_Qww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="/4djzC0ZDFNHPdW9"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmoZmffymTYV52+a6QFYMAnLe-v4U_P-yqwxqJZ38Hc_Qww@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z9iGZ14YlMGZwBnw%40nathan>
Precedence: bulk


--/4djzC0ZDFNHPdW9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Mar 17, 2025 at 04:04:45PM -0400, Robert Haas wrote:
> On Mon, Mar 17, 2025 at 3:34 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> * Once committed, I should update one of my buildfarm animals to use
>>   PG_TEST_PG_UPGRADE_MODE=--swap.
> 
> It would be better if we didn't need a separate buildfarm animal to
> test this, because that means you won't get notified by local testing
> OR by CI if you break this. Can we instead have one test that checks
> this which is part of the normal test run?

That's what I set out to do before I discovered PG_TEST_PG_UPGRADE_MODE.
The commit message for b059a24 seemed to indicate that we don't want to
automatically test all supported modes, but I agree that it would be nice
to have some basic coverage for --swap on CI/buildfarm regardless of
PG_TEST_PG_UPGRADE_MODE.  How about we add a simple TAP test (attached),
and I still plan on switching a buildfarm animal to --swap for more
in-depth testing?

-- 
nathan

--/4djzC0ZDFNHPdW9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v6-0001-initdb-Add-no-sync-data-files.patch"