Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 18 Mar 2025 09:50:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Pipelining support in psql
Message-ID: <Z9jDU_v_eGbZNkCU@paquier.xyz>
References: 
 <CAGECzQRe3pHYvEAZz5Nv9AKzS2nYFLKEfgQCgd5Gr54Um5UFHg@mail.gmail.com>
 <d8aa9cb9-2fa1-464e-b1f1-63a68924b95f@manitou-mail.org>
 <CAO6_Xqq4JEHRaGyC=r+dpi0Ejbp2P3aUo-KfR2NuipCvE-o_ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2+38cXZM9umAIOhK"
Content-Disposition: inline
In-Reply-To: 
 <CAO6_Xqq4JEHRaGyC=r+dpi0Ejbp2P3aUo-KfR2NuipCvE-o_ZA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9jDU_v_eGbZNkCU%40paquier.xyz>
Precedence: bulk


--2+38cXZM9umAIOhK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 17, 2025 at 10:50:50AM +0100, Anthonin Bonnefoy wrote:
> 0001: This introduces the \sendpipeline meta-command and forbid \g in
> a pipeline. This is to fix the formatting options of \g that are not
> supported in a pipeline.

- count=20
--------
-     4
-(1 row)

This removal done in the regression tests was not intentional.

I have done some reordering of the code around the new meta-command so
as things are ordered alphabetically, and applied the result.

> 0002: Allows ';' to send a query using extended protocol when within a
> pipeline by using PQsendQueryParams with 0 parameters. It is not
> possible to send parameters with extended protocol this way and
> everything will be propagated through the query string, similar to a
> simple query.

I like the simplicity of what you are doing here, relying on
PSQL_SEND_QUERY being the default so as we use PQsendQueryParams()
with no parameters rather than PQsendQuery() when the pipeline mode is
not off.

How about adding a check on PIPELINE_COMMAND_COUNT when sending a
query through this path?  Should we check for more scenarios with
syncs and flushes as well when sending these queries?
--
Michael

--2+38cXZM9umAIOhK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfYw1MACgkQnvQgOdby
QH2wBhAAhl8FPtJwiJh6/s70dzWtOHntMds+Uvhk+4k7hesW+iNN547mNdgmQch1
7PD+yp/f3ke7d0Z2UWf+5415/mnfrksFw/2syp0kmlVzBrcgebnBJ4QbAjwI39eN
Peg8cp1JDliWfpob0SJhliTXuUnUp1sYjv69jHHYTwCbyrarzQ4r1l/wylR4sR+U
raZEB6AporC9ej7JYgOK5jADFSTVxefIqPmNdHmCL9KD/HfvynbDUE1h+gN0JZMU
6hWAq5YAgcClayTDHgGhTLYeiLhCnylVierkA1E5elKwV6CVBbFFmEGixYOFl5JK
IZpk/tIotYw5NqEc1c7wUf5RgXw58FYszY/DBw+qZ/w/S8BI03pBsc5X0lvmaDfZ
uM/TE47FhaIwemBjh6ByptNFR1kJIxlIqApm83QrfsFQEipk3w7HewH2DtXK5OFk
bHDTLaKzacZ+zLvENDz5+v6S2BVwHtTxzgX5Rj4y5X8C+iqfVdJMsgCevlR3iY2S
F9m6J7RasAmje8lJP5O0BOo7eBZ6Y1DkCGkwV7E7yE65r1aKXVqJn5UAcqLRaXeL
aGNYWun2YEdWwN6fKA0aQBaN5uwMplgYear54opIvbuIz6HMci6ixWpejFFC3WoB
aP0lv71P0xuAGgKs9rrU/9pjuS9NY+TFoxrfkp1+QCW54lYLnN0=
=UUZ3
-----END PGP SIGNATURE-----

--2+38cXZM9umAIOhK--