Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 18 Mar 2025 16:31:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	Lukas Fittl <lukas@fittl.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Marko M <marko@pganalyze.com>, Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a
 query
Message-ID: <Z9khOo14yzZHCnmn@paquier.xyz>
References: 
 <CAA5RZ0vkNBGmz_ffiKN8vqD9S2rWH=dLXOM9d3uqN+qhefHBxw@mail.gmail.com>
 <202502131125.3kk6id4tcrtv@alvherre.pgsql>
 <CAA5RZ0vnAdfJjAQQjxYLjS-zrkXBjwRrT=+uSFP7YPtWioErig@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dny/726ZrxegT17Y"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0vnAdfJjAQQjxYLjS-zrkXBjwRrT=+uSFP7YPtWioErig@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9khOo14yzZHCnmn%40paquier.xyz>
Precedence: bulk


--dny/726ZrxegT17Y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 13, 2025 at 10:44:33AM -0600, Sami Imseih wrote:
> The reason for the change is because "query jumble" will no longer
> make sense if the jumble code can now be used for other types of
> trees, such as Plan.
>=20
> I do agree that this needs a single-threaded discussion to achieve a
> consensus.

FWIW, I was playing with a sub-project where I was jumbling a portion
of nodes other than Query, and it is annoying to not have a direct
access to jumbleNode().  So, how about doing the refactoring proposed
in v5-0002 with an initialization routine and JumbleNode() as the
entry point for the jumbling, but not rename the existing files=20
queryjumblefuncs.c and queryjumble.h?  That seems doable for this
release, at least.

I don't think that we should expose AppendJumble(), either.
--
Michael

--dny/726ZrxegT17Y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfZIToACgkQnvQgOdby
QH053hAAkWzZqKuE3vRnxyVmdmCMLZJgQEynj8oH1X0ID1rRawna8HH8RKCNU+kj
zCapp0LD/LD//TtdTFNa2jYYT9WZdnOFG81GSuPBawVIj+5FolKPZuCGgDcNldn+
GhcEjGtCTx4MLtiTDiHVJNCLx1Jc/ycLTkmU88PiCXIDOqJSezA9u4l6fTDam59j
PIv46jjs04OPOxItaCwprs9ZRowAr7HM5L1ubaNUv6G/TUvbOu3YNTlTfolDRaGI
Q36WxrmTy65ROuOWUvnjt2BlAsao5ubZuk+R4lDCpfacAXDnafU2ezriImFQZJoj
L4GEwTGHnp5sqXTWMBEpQG/uB9AiCAHZgT0nQB3ZD8DQB9xtPhOepUlPDPuMFefe
3QSBd0hKUWX4Z2klBI7rqeG2lhL3Z/LAbbx5uwBw37A5DDBYJpclsmRpEz7Q30yU
h85JwOMmqnDOi5RajnhLYaSfeWP0BhE1D5T21uD9jpcGZVkcxa8xvQ7tc6cnTDr3
7/ZbydklRd8CC+6K/z59/8BAk4fZBAN9mUc6a3OG29eHaCJb7AMuK+pEA2+/YvOc
N/wQaon26v83m+dweoCJd3x1mNB1CtPH3lI37xhC6sgDGnBEeh419VZBi7I1z7iC
BgRV5t0njWCoKy5vbpGYtjiyHnX8bJQM+Mej/ktlkShF0xKtxms=
=bBT6
-----END PGP SIGNATURE-----

--dny/726ZrxegT17Y--