Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 18 Mar 2025 17:11:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Xuneng Zhou <xunengzhou@gmail.com>, pgsql-hackers@lists.postgresql.org,
	Andres Freund <andres@anarazel.de>
Subject: Re: Fwd: [BUG]: the walsender does not update its IO statistics
 until it exits
Message-ID: <Z9kqluRp_museTIP@paquier.xyz>
References: <Z73IsKBceoVd4t55@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z762lusJXp_wNF_z@paquier.xyz>
 <Z77jgvhwOu9S0a5r@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8FMjlyNpNicucGa@paquier.xyz>
 <Z8GSY8mk+0qVHzsW@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8ULFzNY24_SMCdu@paquier.xyz>
 <Z8WYf1jyy4MwOveQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <CABPTF7U5B1gnvvrbk+we+Zi3p0-KKAEXYCLj914T9Fm5Cjk1LA@mail.gmail.com>
 <CABPTF7VreDnD3YiWzx_=PpLRdgOQsH8Xp3fTGMc+r9rGpc3WLg@mail.gmail.com>
 <Z9LbNVAZrMinORG7@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="EGaX9gB4mTGj3eIQ"
Content-Disposition: inline
In-Reply-To: <Z9LbNVAZrMinORG7@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9kqluRp_museTIP%40paquier.xyz>
Precedence: bulk


--EGaX9gB4mTGj3eIQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 13, 2025 at 01:18:45PM +0000, Bertrand Drouvot wrote:
> This particular sub-patch needs a rebase though, done in the attached. 0001
> remains unchanged as compared to the v4 one just shared up-thread. If 0001 goes
> in, merging 0002 would be less beneficial (as compared to v3).

PgStat_PendingIO is already quite large, could get larger, and the
backend stats would be a natural victim of that.  What you are
proposing in v4-0002 is beneficial in any case outside of the specific
problem of this thread with WAL senders.  It is new code on HEAD and
pgstat_flush_backend_entry_io() being the only entry point where IO
data is appended makes it easy to reason about.  Just to say that I am
planning to apply this part on HEAD.
--
Michael

--EGaX9gB4mTGj3eIQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfZKpYACgkQnvQgOdby
QH1HLw//cUbln/ZXGSpijTBN10hEYV0bHLY85qON8jSsUuX7nuTyvcDe1dg/3pUV
RCD4BK4XQKZMtA8trf+VHbV2Vm0UNG9WgtK9y7BTWu0xW9Gck04ODGcEPrF6+1y3
82ih/84Bk+pFAQ/eLLCBHqu3Qhl8ZlEUrSQN6A9KjguVMZNijkEWeiKYrlqwbMZI
QkAMrT6/uzKiQA4B2MZxY3EW/dA12iPMSxISlsSJyE0mvpJR/kGKbshKKVstic/4
IsMBNWW1DOYt2q3Yy0iX8Pp9kmu25wCIlAT7XMba7B/nCyBGqi0/752J5RBaZYHU
X4T8nmccv0DE0O6Mc/v0flNbJgbRD8JpDo3j7+9BHOQUgp0E16Q7Qd0FDnU+Z4vC
mactkEml9GFBVYDYI0wYJ/SIhCNNQQxrNDH1d+8asGHFn9TwuMr6jJtnfHzgSqIp
A5oRbsbcCTwyfWNRQ6xoE/Tn3XEpZA9WkagL/rX1Q7WstIlRyyb6K9D2oNbitQ7N
dc8XKqJJoyLa5aSWa+lSM0cdxGZ6ziZXkN5kZ2U7cFSVbNn9rQqmFuFHwhMfhuXy
cuH+o5gtWvDaTSs5Rk44Ou4e/vG+SzC4F1CCwG/d9BjihiyqVddwtInfYIiFsYRZ
OtWScS+MdGVY0TXoOf7Zvc45Jr3kyiSa7C9cV9jE5Vr2BKDH2jE=
=b8jw
-----END PGP SIGNATURE-----

--EGaX9gB4mTGj3eIQ--