Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 19 Mar 2025 13:49:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Pipelining support in psql
Message-ID: <Z9pM02F2AUrQZWhl@paquier.xyz>
References: 
 <CAGECzQRe3pHYvEAZz5Nv9AKzS2nYFLKEfgQCgd5Gr54Um5UFHg@mail.gmail.com>
 <d8aa9cb9-2fa1-464e-b1f1-63a68924b95f@manitou-mail.org>
 <CAO6_Xqq4JEHRaGyC=r+dpi0Ejbp2P3aUo-KfR2NuipCvE-o_ZA@mail.gmail.com>
 <Z9jDU_v_eGbZNkCU@paquier.xyz>
 <CAO6_Xqo=fNh0KCRZG7T18OZfjiabeL-t4C6mkXsz-3dAZ1YwTA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Fhnh6ohuBxQY06fc"
Content-Disposition: inline
In-Reply-To: 
 <CAO6_Xqo=fNh0KCRZG7T18OZfjiabeL-t4C6mkXsz-3dAZ1YwTA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9pM02F2AUrQZWhl%40paquier.xyz>
Precedence: bulk


--Fhnh6ohuBxQY06fc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 18, 2025 at 09:55:21AM +0100, Anthonin Bonnefoy wrote:
> I've added additional tests when piping queries with ';':
> - I've reused the same scenario with \sendpipeline: single query,
> multiple queries, flushes, syncs, using COPY...
> - Using ';' will replace the unnamed prepared statement. It's a bit
> different from expected as a simple query will delete the unnamed
> prepared statement.
> - Sending an extended query prepared with \bind using a ';' on a
> newline, though this is not specific to pipelining. The scanned
> semicolon triggers the call to SendQuery, processing the buffered
> extended query. It's a bit unusual but that's the current behaviour.

The tests could be much more organized, particularly for the "sinple"
and "multiple" and COPY cases, rather than being treated as two
different groups at different locations of psql_pipeline.sql.  I've
spent some time reorganizing all that.

A second thing that was a bit itchy is the use of ";" for what's a
semicolon, and we use this term in the psql docs to refer to queries
terminated by that.  The whole paragraph could be simplified a bit
more, mentioning that everything in a pipeline uses the extended
protocol, while \bind & co are more like options.  The description of
PIPELINE_COMMAND_COUNT could be simpler, and the part about the
pending results can be more general now so I've removed it.

With all that set, I've applied the patch.  If you have more
suggestions, please feel free to mention them.
--
Michael

--Fhnh6ohuBxQY06fc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfaTNIACgkQnvQgOdby
QH3mIA//Svo6TPV75rkGZmVrNFchCD9ZiBOFT5rfVn/CcR4gkVMTVESoC8IsJU79
0gL8VkB+UEZcxyLZ28l75F9WNRBbqBUbLop9X3Y+7633z3ao4JFT3SiuHA0hr54a
4rEPJg1HjqibqZz65WgPnTdSG87tsdxcr1ryquj0A6EOgWE7cJQiAhnnPf0PG0X5
7asjd+H8MgGxvPuTHrFWjqMRH7rFLKaZZA94EcJ5M9pt7Zutjec8RM7eOCvWDvsf
gCp2ux3rFu4/xKmGKLwzKfpRayE+aVxgMD0iEO0hLpZF5wt8mM94asQdYW1CqRSS
ZpFagcz4/eDH/yi08RplCTgG1LTEARIl6NBQEWWCiau9/i30iIS8OA00AAOBVA80
Y9Yc3Uv/ni8VSHg+uHtnKe2YrtpRpnKWO5bBU+Ul2kFxH9O/9qgWUF1U+4aP871M
reS7NH85lJ8gfQTOnbAsq2HcFPQyXT0Qc0a9C3p/t1IxAIJe97Q7Ieb8fx2q7Qhv
dDBeeYzT2RWB/Wa187D/+djZZBC1akXGyLnGqfvH1s2AwlOhND4Kw0TCeBEeRMXc
LyNIhOQl1QhFanPWXC0HKLC575+Z/KRPrdeuBycJKCN9FAOe8USISVE1s2hhNEAn
wFGofXxyLmQzqXhdr33+htZXmBELyWcMDhaRYxAsDkpeW0Eb48E=
=hVVP
-----END PGP SIGNATURE-----

--Fhnh6ohuBxQY06fc--