Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 21 Mar 2025 14:53:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
	Noah Misch <noah@leadboat.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Euler Taveira <euler.taveira@enterprisedb.com>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: [PATCH] pg_stat_activity: make slow/hanging authentication more
 visible
Message-ID: <Z9z-yLbxq-mO2squ@paquier.xyz>
References: <qvqojlk7efqr47xluqsvvuxvc6vbxjkn3jaqvcgnctmimvs2us@t3a7xrvblm2r>
 <CAOYmi+=fVn7GJNEvtMBDZD_25S40iFD3r7PLOS6gOwJMAdEwMQ@mail.gmail.com>
 <dg7ipxk4onfxczykzzslrbyznmc4zjhqc5dnrshwcljlxeacuw@jxpayo4oe4ep>
 <CAOYmi+nkEPh4724NKci7hFiZBbu4WEO99bL7=fu+EvTAb3N8uw@mail.gmail.com>
 <CAOYmi+nTu397-5NEVd2sG0-=gxZO5ZDKrTbN78dmS2ExAgm=UA@mail.gmail.com>
 <CAOYmi+kDb9pgoLm58E0HrmFRNkaJGiquyBkRMX5TBhRQomnL3A@mail.gmail.com>
 <esdlq5fxviqcio4hnnedvnsr7hqz6zjq5slww2ofdverzmdocp@5mztuvygi4bw>
 <CAOYmi+=ukHDn2hEGD=0tNMv_JC5V7NYKhKCKRQkiPZo-uNzd6w@mail.gmail.com>
 <rkej7nbahcoeaonn3dxdbk2wzsi2gi3l75mse7txzigleggk3c@egrki7isobok>
 <CAOYmi+kmQoEvQScecGaD-Ta1RG=uiipLQESBibxrtpyq7V6gpA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xPJhzt5FfLAwg9sb"
Content-Disposition: inline
In-Reply-To: 
 <CAOYmi+kmQoEvQScecGaD-Ta1RG=uiipLQESBibxrtpyq7V6gpA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z9z-yLbxq-mO2squ%40paquier.xyz>
Precedence: bulk


--xPJhzt5FfLAwg9sb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 17, 2025 at 10:22:47AM -0700, Jacob Champion wrote:
> I looked into switching over to pgstat_report_activity(), but that
> wasn't designed to be called in the middle of backend initialization.
> It would take more work to make those calls safe/sane when `st_state
> =3D=3D STATE_STARTING`. I plan to mark this patchset as Withdrawn for now.

Okay, fine by me.  I had the impression that it would have been
possible to salvage some of the wait event states, but at least the=20
starting state showing up in pg_stat_activity will be able to provide
some information, so it's better than none.  Unfortunately, I don't
have any room until the feature freeze for that.

Outside the stat report activity calls, I've been wondering if we
should add some dynamic tracking of which hba/ident entry a backend
PID is working with.  For example, if we knew the file and the entry
line number, we would know on which auth method this backend is
bumping into.  That maybe of course limited if someone modifies and
reloads the HBA file while a backend is stuck.  Now, these files are
mostly static, and we have system views that provide the contents of
the ident and HBA files as SQL, so with a JOIN..
--
Michael

--xPJhzt5FfLAwg9sb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfc/sgACgkQnvQgOdby
QH16LQ/+MDXYKv2Tqew7WOa/JWz2wZWp6oFiHfMOds5OI2qO23CjFQrcMyy4nhXo
hjD6GHBr1nSRCfj0G63PW7W9ATNsXKgKVD+xDZVRTNoAKkRRxsBV0Y2P3S9vzjeP
fVobs7bhImBxpnX5vsfZmF3vKEZUCsOPm9xSY5ZXI2BHYUaR2xKeEHnCLfwOXldP
pCQ+GR6i40ro5DpvFW0BtPgK0Q1Jv4paUpyaqnPXoQqh4BJbwCJ3c/WGjgV51erh
11VSioeLg4NmI/XHQNeF1hy1RUPRI4Hae+jiDx7sQ0elWjGzXi/OQPvk/+BvSnsj
1gVCXfVwkWilkVi0sqL+0hjG0qHf63FX/+Z4FPyxuowkNat5XCibutAkAhFDUlyV
DcC1QPhdMhk85YhMgqZ8VQKMrX1rs3K3tO2uKvnqCc9rBEMz4hMGbhYR5xaTKnBH
U3atuhW/wJVXph+b4wQhpxXGYkAtOKgzz4VR9kwgBsxiCVFFx5lY0CdeU9BcYQRT
qNjIufzPsYsvBjBwfn5DytSZ4EpzDf+a8/hjbe9BfEoZWRhJeBNVQbmkUg0pa6LW
KHkjLcQIDjjQE+mH9+F1xY+JedKHnN8DVKLDKomuetApvXwIiNzNU4w4xkWH7EE9
9t0aCTBtuIFuvtbvntiy5hf8EvykN/1GmfnbhLfSYY3PmCbpsnM=
=sJqK
-----END PGP SIGNATURE-----

--xPJhzt5FfLAwg9sb--