Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbaLv-0001de-67 for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Mar 2023 05:04:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pbaLs-0000mU-Ij for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Mar 2023 05:04:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbaLq-0000mL-U8 for pgsql-hackers@lists.postgresql.org; Mon, 13 Mar 2023 05:04:04 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbaLi-0002Pw-RW for pgsql-hackers@lists.postgresql.org; Mon, 13 Mar 2023 05:04:02 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3DFEF320027A; Mon, 13 Mar 2023 01:03:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 13 Mar 2023 01:03:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678683830; x=1678770230; bh=qj KBNaIwwPSGICS8DrE0NM/TsNasCNp903KK8+qw2BE=; b=SucmD5RpYLMHT70cwf w2Aj/uoRlX6eQ611+aGvMGsZ1SdwXAr9BgxHRiEsJfE/7a87Lg0HjtTRkavEOkK7 s4xzuIXRgS2tevWr3UPrCHtzd/yPH51H7bKTftXfOBuCC6Gc7CNjv4ZTjpRPkIYp Ix1rRE08DsUYcBAxuLeMGEtaiWINuwMZHU1NT097T2W83YGq5PFI5WYyOs2F6giZ AR+t1fO0+JmDFY0tUSbzvlAe4TltI5pX3fr3bI1596nPn21pPT+VeaurfnZkDnSh wYU1fMshwxdN4wCRVaah5JXpWBgSCQFsBsAKka9R6tDzGKyfq8PnQBzLux6pZI6w ryGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678683830; x=1678770230; bh=qjKBNaIwwPSGI CS8DrE0NM/TsNasCNp903KK8+qw2BE=; b=s7QDypzKygYQvtKrQ7R98BOlc8OAr JTHk04qh+oT3NMbOjMrfJieCvc+4utQaUNkmf/JmEWnS868JVxjfnkMVQuYHejLY Tu1EB9pSWFqnxPJSBS0ar76j+O7USk1mmgD5QWwZxJ9i/fXPGLH6j84H06C//raN 8JihrwGnxnJurR7PPta/ylLocjIzw/rTvc10VeMv6KEbcEMYWj88Ce7dL6Kxy+bD wcLc7r+hidIwhEToGJdvxQBBrSQANFg/rxJvvsW4+qpoAGzd7bQbdwL3KecVUoPj S7qqbuIOafJD9y64F/3yyr7cZ0ju+LpX1azDICYAbjCGVOqGp50LWLLqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Mar 2023 01:03:49 -0400 (EDT) Date: Mon, 13 Mar 2023 14:03:43 +0900 From: Michael Paquier To: Sravan Kumar Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Compilation error after redesign of the archive modules Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QTwVYMO/yYXUnoqz" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --QTwVYMO/yYXUnoqz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 10, 2023 at 05:16:53PM +0900, Michael Paquier wrote: > On Fri, Mar 10, 2023 at 01:41:07PM +0530, Sravan Kumar wrote: >> I have attached a patch that fixes the problem. Can you please review >> if it makes sense to push this patch? >=20 > Indeed, reproduced here. I'll fix that in a bit.. (Sorry for the late reply, I thought that I sent that on Friday but it was stuck in my drafts.) Note that your patch took only care of the ./configure part of the installation process, but it was missing meson. Applied a fix for both as of 6ad5793. -- Michael --QTwVYMO/yYXUnoqz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQOrq8ACgkQnvQgOdby QH1eiRAAmINqZOuVyQjUuDobirqqopavxky/fIZf7c+Jh/To9536ynFuUWi5/Qzd Lc0dBQA/ze0llEbAPCkc44blQgInoo5R3xyZ7Po6DW9Z0tXEUQ5cqRZudba7cfnb YNBJOof0tqe0i8v9jWkw2ygvUz/gio95LnTGPs9s8qEYsIDicGI1Z3GwpkwdEbm4 TFXJlTrlRlqottXkelS+gugoEBOGlcMk3r71ePM//40RwJUXQrha+QLagjeg0/wo NfhM96Gl7x/d0hETfQhdA3/HiMK7ozAPNgbRvIyU9CjB+af5uriNJ+w0ZZTZ9wmG VGwa0L9Vga8Q1giyov0vPlBdUn8OGMtUgjQXbbWUtxajxEXQ+Il27HP5tSYEn+xW AdD5BbTgTz2kZV/pJ6qqJ2hQXRKT74s3mADxAjdMRPiwLsgEcVECdqwid7uB/4d8 DYr637dvmIBVC466WaQDzFVPL7XxfstqSeZvkWjUeK3EqBKNKUyTB42Jcxp/1DAC S7hfXobQEKES5LD/A0BeF7U/9bMK5ME41NhkK4kenBhfTGrAtKxYXVSBK0WjB4RC VSbFVohuErsFTA00hESjQ/Lcb+sa5MeO3DuacC6RRi72YzilzwBLtJLpck/l7Qq8 lfG9NefQECIwAdHIMajMUyxdzfoks+X1g6wu7nvo7P+OpZ0lU8s= =9JhQ -----END PGP SIGNATURE----- --QTwVYMO/yYXUnoqz--