Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 2 Mar 2023 14:21:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: add PROCESS_MAIN to VACUUM
Message-ID: <ZAAyRL4GuUf8jICK@paquier.xyz>
References: <Y/7xVESfLgw3E/F/@paquier.xyz>
 <20230301180953.b64tekcnh43xtzqn@alvherre.pgsql>
 <20230301191344.GA1543729@nathanxps13>
 <CAD21AoCho1inBEyKD9=ZsByxWCWSx3nS+AkXz8nBBVn_9YLWMA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="n3jGppAs0iN0HSFW"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoCho1inBEyKD9=ZsByxWCWSx3nS+AkXz8nBBVn_9YLWMA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZAAyRL4GuUf8jICK%40paquier.xyz>
Precedence: bulk


--n3jGppAs0iN0HSFW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 02, 2023 at 12:58:32PM +0900, Masahiko Sawada wrote:
> Cutting the toast relation name to 'pg_toast' is a bit confusing to me
> as we have the pg_toast schema. How about using the following query
> instead to improve the readability?
>=20
>        SELECT
>        CASE WHEN c.relname IS NULL THEN
>        s.relname
>        ELSE
>        'toast for ' || c.relname
>        END as relname,
>        s.vacuum_count
>        FROM pg_stat_all_tables s
>        LEFT JOIN pg_class c ON s.relid =3D c.reltoastrelid
>        WHERE c.relname =3D 'vactst' OR s.relname =3D 'vactst'

Another tweak that I have learnt to like is to apply a filter with
regexp_replace(), see 090_reindexdb.pl:
regexp_replace(b.indname::text, '(pg_toast.pg_toast_)\\d+(_index)', '\\1<oi=
d>\\2')

If you make that part of the view definition, the result is the same,
so that's up to which solution one prefers.
--
Michael

--n3jGppAs0iN0HSFW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmQAMkQACgkQnvQgOdby
QH2e6RAAjJ24p+mHAYG5jkVt4znxToc1AyHE0dEEELj/IbVtcf5Xt9sRKXPIgnVd
KYGEPXQNw2g/yN0ZJ8eN+fgQJvFwWm0BAjf/mXutenaiYOncIqJD6AeQ5j6yPw8i
xi7l4yb+CsV/4g/lFQrZ+W6CBJskvOCQfWcL5fd6gCkN4c3WGJA+vtMfpKpBMXSu
XRMZIRmRzicvQWsDjgijPxFxYYxnDndKYpyrQvkmPcz/R6ysEqQyrGJ2y8L4lpCw
8FruqpJdBZ+yWK6gzU2FPFp0OjatAEbXEi/UMU2fCLZifFDBA14BgWHE8vtaWRvt
4ircmOY7pETvEQBiAS2oUrKOPCsx4EZ/cCZlawzv24etio8zll16ICQEadKFA2DU
o4/Sb254boT/BQy8wwOoVRN+5mbAK5YXDRBb+euLT4TnIzhy5FmHuh6YuVTXf+Lt
sTERaegOJRlnH0V15X7FP58JfNgfbACEdbeHMjpLGiaeIKaofg5q0jI+Rt8G6fm1
PqpfcqFvxBeSyYTIJoE0tS9mSP5f2ez+B/mpmvaBa/QZy3pDrCZLpzD8walb+RLL
62HbMxCvX5H5Wwv+wRGT3YGvo4Hr9N75tPSI63hz8YMCKvUWMTTvXSAYa5W/OLau
zOzek1ESAQDQVolXUgxHex6dN5zf4zL2HI7RaiZargiT3NDikvs=
=wSZ0
-----END PGP SIGNATURE-----

--n3jGppAs0iN0HSFW--