public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?
Date: Mon, 6 Mar 2023 13:29:50 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACXr0Wjf1C70y=YGa_P_1rzPS0UT3fod0Ajx+gA3OkMpvQ@mail.gmail.com>
References: <[email protected]>
<CALj2ACUmvGb78zd49OXcRWvTX1WYHnOcF6oikQiR2i2yH4zvgw@mail.gmail.com>
<[email protected]>
<CALj2ACXEBwY_bM3kmZEkYpcXsM+yGitpYHi4FdT6MSk6YRtKTQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<Y+8qkqMWISW5Pta/@paquier.xyz>
<[email protected]>
<Y/[email protected]>
<CALj2ACXr0Wjf1C70y=YGa_P_1rzPS0UT3fod0Ajx+gA3OkMpvQ@mail.gmail.com>
On Mon, Feb 20, 2023 at 01:54:00PM +0530, Bharath Rupireddy wrote:
> I ran some tests on my dev system [1] and I don't see much difference
> between v3 and v4. So, +1 for v3 patch (+ argument order swap) from
> Andres to keep the code simple and elegant.
This thread has stalled for a couple of weeks, so I have gone back to
it. Testing on a tmpfs I am not seeing a difference if performance
for any of the approaches discussed. At the end, as I am the one
behind the introduction of pg_pwrite_zeros(), I have applied v3 after
switches the size and offset parameters to be the same way as in v4.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox